-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Add a label to PRs when a backport fails #39
Comments
I guess this relates to #12. Perhaps @felixfontein's idea to add a different label when a backport suceeds is a better one. |
Sometimes backporting fails without the backporting bot code completing (bug, or process is killed). In that case adding a label won't work. |
Thanks for the suggestion! Some kind of a design vision / UX / config structure would be welcome. As for the crashes, I'd mention the case of GitHub's own eventual consistency and outages. Still, we could probably do an optimistic "best effort", like other apps. |
Note that when you talk about a failing backport and just one label, it might be confusing as people often request backporting to many branches. The newest ones succeed while the older ones might be more suseptible to conflicts. It might end up being a confusing thing. Also note that the bot is stateless. |
Yeah, sure. I'll give it more thought. |
I proposed a solution in #40. |
It would be nice if patchback allowed adding a label to PRs when a backport fails. The label name should be configurable.
Upvote & Fund
The text was updated successfully, but these errors were encountered: