Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add a label to PRs when a backport fails #39

Open
gotmax23 opened this issue Oct 12, 2023 · 6 comments · May be fixed by #40
Open

[FR] Add a label to PRs when a backport fails #39

gotmax23 opened this issue Oct 12, 2023 · 6 comments · May be fixed by #40

Comments

@gotmax23
Copy link

gotmax23 commented Oct 12, 2023

It would be nice if patchback allowed adding a label to PRs when a backport fails. The label name should be configurable.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@gotmax23
Copy link
Author

I guess this relates to #12. Perhaps @felixfontein's idea to add a different label when a backport suceeds is a better one.

@felixfontein
Copy link

Sometimes backporting fails without the backporting bot code completing (bug, or process is killed). In that case adding a label won't work.

@webknjaz
Copy link
Member

Thanks for the suggestion! Some kind of a design vision / UX / config structure would be welcome. As for the crashes, I'd mention the case of GitHub's own eventual consistency and outages. Still, we could probably do an optimistic "best effort", like other apps.

@webknjaz
Copy link
Member

Note that when you talk about a failing backport and just one label, it might be confusing as people often request backporting to many branches. The newest ones succeed while the older ones might be more suseptible to conflicts. It might end up being a confusing thing.

Also note that the bot is stateless.

@gotmax23
Copy link
Author

Thanks for the suggestion! Some kind of a design vision / UX / config structure would be welcome.

Yeah, sure. I'll give it more thought.

@gotmax23 gotmax23 linked a pull request Oct 13, 2023 that will close this issue
@gotmax23
Copy link
Author

I proposed a solution in #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants