Allow adding labels when a backport fails #40
Conversation
These wrappers follow the same conventions as the other *_api modules.
This will be used for the new labels API.
This adds a label when a backport fails and removes the original backport label. This makes it easier to identify failures without having to open up the issue and scroll all the way down.
Ensure backport_label_prefix and failed_label_prefix are different to avoid infinite loops.
gotmax23
force-pushed
the
failure_label
branch
2 times, most recently
from
ae57f20
to
d91840a
Compare
| # Delete backport label | ||
| await issue_labels_api.remove_label(backport_label) |
There was a problem hiding this comment.
I'm debating whether it makes sense to also drop the existing backport label on failures. Wdyt?
There was a problem hiding this comment.
A-la #12? That'd need to be a separate PR.
|
I'll probably have to add the standard linting I usually have in my projects before going through the review. I noticed some style deviations that I'd rather delegate to automatic systems. I haven't done so because barely anybody contributed and I usually know what I want anyway. Anyway, I don't think I'll get to it today as the GitHub Apps are getting kicked out of the OpenShift cluster that is going away for good tomorrow. So I'm prioritizing migrating them to OSCI today. |
This adds a label when a backport fails and removes the original
backport label.
This makes it easier to identify failures without having to open up the
issue and scroll all the way down.
Example run:
backport-2.15labelfailed-backport-2.15label if it doesn't already existfailed-backport-2.15labelbackport-2.15Fixes: #39