chore(deps): update linters to v8 (major) (#1353)

* chore(deps): update linters to v8 * chore: fix lint --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Cody Olsen <[email protected]>
sanity-io · Jan 27, 2025 · 3daeca8 · 3daeca8
1 parent c21ab13
commit 3daeca8
Show file tree

Hide file tree

Showing 7 changed files with 96 additions and 103 deletions.
diff --git a/package.json b/package.json
@@ -143,8 +143,8 @@
     "@types/semver": "^7.5.8",
     "@types/treeify": "^1.0.3",
     "@types/uuid": "^10.0.0",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
+    "@typescript-eslint/eslint-plugin": "^8.21.0",
+    "@typescript-eslint/parser": "^8.21.0",
     "browserslist-to-esbuild": "2.1.1",
     "commitizen": "^4.3.1",
     "cpx": "^1.5.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/node/check.ts b/src/node/check.ts
@@ -120,6 +120,7 @@ async function checkExports(
     }
 
     const esbuildWarnings = esbuildResult.warnings.filter((msg) => {
+      // eslint-disable-next-line @typescript-eslint/no-unused-expressions
       !(msg.detail || msg.text).includes(`does not affect esbuild's own target setting`)
     })
 

diff --git a/src/node/core/config/loadConfig.ts b/src/node/core/config/loadConfig.ts
@@ -31,7 +31,7 @@ export async function loadConfig(options: {cwd: string}): Promise<PkgConfigOptio
 
   const {unregister} = globalThis.__DEV__ ? {unregister: () => undefined} : register(esbuildOptions)
 
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
+  // eslint-disable-next-line @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports
   const mod = require(configFile)
 
   unregister()

diff --git a/src/node/fileExists.ts b/src/node/fileExists.ts
@@ -6,7 +6,7 @@ export function fileExists(filePath: string): boolean {
     statSync(filePath)
 
     return true
-  } catch (_) {
+  } catch {
     return false
   }
 }
diff --git a/src/node/templates/default/template.ts b/src/node/templates/default/template.ts
@@ -33,7 +33,7 @@ export const defaultTemplate: PkgTemplate = async ({cwd, logger, packagePath}) =
             gitUrlParse(v)
 
             return true
-          } catch (err) {
+          } catch {
             return 'invalid git url'
           }
         },

diff --git a/test/env/spawnProject.ts b/test/env/spawnProject.ts
@@ -47,7 +47,7 @@ export function spawnProject(name: string): Promise<{
             return
           }
 
-          // eslint-disable-next-line @typescript-eslint/no-var-requires
+          // eslint-disable-next-line @typescript-eslint/no-var-requires, @typescript-eslint/no-require-imports
           const pkg = require(path.resolve(tmpPath, 'package.json'))
 
           async function runExec(cmd: string) {
@@ -85,6 +85,7 @@ export function spawnProject(name: string): Promise<{
             readFile: (filePath: string) =>
               fs.readFile(path.resolve(tmpPath, filePath)).then((r) => r.toString()),
             remove: tmpRemove,
+            // eslint-disable-next-line @typescript-eslint/no-require-imports
             require: (id) => require(path.resolve(tmpPath, id)),
             run: (cmd: string) => runExec(`pnpm run ${cmd}`),
           })
-Original file line number
+Diff line change
@@ Expand Up / @@ -120,6 +120,7 @@ async function checkExports( @@
         }
         const esbuildWarnings = esbuildResult.warnings.filter((msg) => {
+          // eslint-disable-next-line @typescript-eslint/no-unused-expressions
           !(msg.detail || msg.text).includes(`does not affect esbuild's own target setting`)
         })
@@ Expand Down @@