-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Global Document References support #8299
base: next
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
9caf5d8
to
691aad1
Compare
9d4c639
to
2fbe79b
Compare
No changes to documentation |
Component Testing Report Updated Mar 11, 2025 12:16 PM (UTC) ❌ Failed Tests (1) -- expand for details
|
⚡️ Editor Performance ReportUpdated Tue, 11 Mar 2025 14:25:26 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
2fbe79b
to
9f5974c
Compare
f80acdb
to
d5265ee
Compare
d5265ee
to
5a7e271
Compare
…requsts and listeners
This is needed to be able to write global document references through mutations.
00666c2
to
39db37e
Compare
Renamed references to routes that is currently being renamed in the API. |
if (!resourceType) { | ||
return 'The resource type must be a non-empty string' | ||
} | ||
if (resourceType != 'asset-library' && resourceType != 'dataset') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be media-library
?
return 'The resource type must be a non-empty string' | ||
} | ||
if (resourceType != 'asset-library' && resourceType != 'dataset') { | ||
return 'The resource type must be either "asset-library" or "dataset"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it say "media-library" here?
Description
This is @skogsmaskin writing BTW 👋
This will add support for Global Document References (GDR) in the Studio. A Global Document Reference can reference something inside another project across the user's Sanity organization.
The implementation is very much alike cross-dataset-references, but there is a separate schema type that has it's unique config options:
We don't want to release this yet to the public just yet, but it would be great if we could start reviewing it, so that it's ready to go when we need it. It also makes it possible to get some more test usage before we announce it.
What to review
next
.Testing
Open up the test studio in this branch, and select "playground (Staging)" workspace. Go to "Standard Inputs" and "Global document references test":
There is also added some automatic tests.
Note that the API currently only works in staging, and needs to be released first.
Notes for release
N/A - not to be announced yet.