Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add default values to releases metadata #8484

Merged

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Feb 4, 2025

Description

Releases metadata is not a system property, so in some cases this info could not exist.
This modifies the query we use to fetch them and adds default values if the object doesn't exist.

What to review

Testing

Create a release with no metadata outside of the studio, the studio should load with the default values.

Notes for release

@pedrobonamin pedrobonamin requested a review from juice49 February 4, 2025 07:14
@pedrobonamin pedrobonamin requested a review from a team as a code owner February 4, 2025 07:14
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 7:19am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 7:19am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 7:19am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 4, 2025 7:19am
test-next-studio ⬜️ Ignored (Inspect) Feb 4, 2025 7:19am

Copy link
Contributor

github-actions bot commented Feb 4, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Component Testing Report Updated Feb 4, 2025 7:24 AM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 10s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 20s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 36s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 2s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚡️ Editor Performance Report

Updated Tue, 04 Feb 2025 07:26:22 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.3 efps (43ms) 24.1 efps (42ms) -2ms (-3.5%)
article (body) 70.2 efps (14ms) 72.5 efps (14ms) -0ms (-/-%)
article (string inside object) 26.3 efps (38ms) 25.0 efps (40ms) +2ms (+5.3%)
article (string inside array) 22.7 efps (44ms) 22.0 efps (46ms) +2ms (+3.4%)
recipe (name) 52.6 efps (19ms) 50.0 efps (20ms) +1ms (+5.3%)
recipe (description) 58.8 efps (17ms) 55.6 efps (18ms) +1ms (+5.9%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (5ms) -1ms (-/-%)
synthetic (title) 18.7 efps (54ms) 18.5 efps (54ms) +1ms (+0.9%)
synthetic (string inside object) 19.6 efps (51ms) 18.2 efps (55ms) +4ms (+7.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 49ms 79ms 372ms 492ms 10.8s
article (body) 14ms 17ms 18ms 51ms 228ms 5.3s
article (string inside object) 38ms 41ms 51ms 241ms 321ms 6.9s
article (string inside array) 44ms 47ms 53ms 307ms 426ms 7.5s
recipe (name) 19ms 21ms 23ms 40ms 0ms 7.2s
recipe (description) 17ms 19ms 20ms 30ms 0ms 4.3s
recipe (instructions) 6ms 8ms 9ms 10ms 0ms 3.1s
synthetic (title) 54ms 57ms 60ms 314ms 970ms 12.1s
synthetic (string inside object) 51ms 55ms 68ms 289ms 707ms 8.2s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 42ms 45ms 67ms 506ms 864ms 10.5s
article (body) 14ms 17ms 25ms 214ms 323ms 5.4s
article (string inside object) 40ms 42ms 47ms 277ms 361ms 7.1s
article (string inside array) 46ms 50ms 55ms 264ms 392ms 7.6s
recipe (name) 20ms 22ms 24ms 48ms 0ms 7.2s
recipe (description) 18ms 19ms 22ms 36ms 0ms 4.7s
recipe (instructions) 5ms 7ms 8ms 10ms 0ms 3.0s
synthetic (title) 54ms 58ms 63ms 178ms 975ms 12.9s
synthetic (string inside object) 55ms 60ms 70ms 466ms 1500ms 9.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@pedrobonamin pedrobonamin merged commit 0a24d7c into feat/content-releases Feb 4, 2025
57 checks passed
@pedrobonamin pedrobonamin deleted the feat/content-releases-default-metadata branch February 4, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants