Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): add node 22 to test matrix #8502

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Feb 4, 2025

Description

Node 22 has been out for a closer to a year now, so time to add it to our test matrix I guess :)

Notes for release

n/a internal

@bjoerge bjoerge requested a review from a team as a code owner February 4, 2025 21:49
@bjoerge bjoerge requested review from jordanl17 and removed request for a team February 4, 2025 21:49
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 9:49pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 9:49pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 9:49pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 4, 2025 9:49pm
test-next-studio ⬜️ Ignored (Inspect) Feb 4, 2025 9:49pm

Copy link
Contributor

github-actions bot commented Feb 4, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Component Testing Report Updated Feb 4, 2025 9:55 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 4s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 19s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 30s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 2s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Feb 4, 2025

⚡️ Editor Performance Report

Updated Tue, 04 Feb 2025 21:57:48 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 24.4 efps (41ms) 24.4 efps (41ms) +0ms (-/-%)
article (body) 72.5 efps (14ms) 78.1 efps (13ms) -1ms (-/-%)
article (string inside object) 26.3 efps (38ms) 25.6 efps (39ms) +1ms (+2.6%)
article (string inside array) 22.7 efps (44ms) 23.3 efps (43ms) -1ms (-2.3%)
recipe (name) 45.5 efps (22ms) 50.0 efps (20ms) -2ms (-9.1%)
recipe (description) 43.5 efps (23ms) 52.6 efps (19ms) -4ms (-17.4%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (5ms) -1ms (-/-%)
synthetic (title) 17.9 efps (56ms) 18.7 efps (54ms) -3ms (-4.5%)
synthetic (string inside object) 19.2 efps (52ms) 18.3 efps (55ms) +3ms (+4.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 60ms 88ms 471ms 1108ms 10.9s
article (body) 14ms 17ms 32ms 225ms 461ms 5.3s
article (string inside object) 38ms 41ms 56ms 86ms 266ms 7.0s
article (string inside array) 44ms 46ms 52ms 306ms 523ms 7.4s
recipe (name) 22ms 24ms 26ms 42ms 0ms 7.4s
recipe (description) 23ms 24ms 26ms 63ms 0ms 5.1s
recipe (instructions) 6ms 7ms 8ms 9ms 0ms 3.2s
synthetic (title) 56ms 59ms 78ms 326ms 1459ms 13.6s
synthetic (string inside object) 52ms 56ms 70ms 445ms 735ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 47ms 57ms 451ms 1004ms 10.7s
article (body) 13ms 15ms 27ms 243ms 316ms 5.2s
article (string inside object) 39ms 43ms 48ms 223ms 385ms 7.1s
article (string inside array) 43ms 46ms 51ms 157ms 407ms 7.1s
recipe (name) 20ms 22ms 24ms 49ms 0ms 6.9s
recipe (description) 19ms 20ms 24ms 55ms 0ms 4.7s
recipe (instructions) 5ms 7ms 9ms 27ms 0ms 3.2s
synthetic (title) 54ms 55ms 57ms 294ms 849ms 13.1s
synthetic (string inside object) 55ms 58ms 73ms 357ms 1229ms 8.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@bjoerge bjoerge enabled auto-merge February 5, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant