Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): swap sanity-diff-patch with @sanity/diff-patch #8503

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Feb 5, 2025

Description

As the PR title says. No API changes beyond the module name being changed.

What to review

Undo changes still work as expected

Testing

Relying on existing tests

Notes for release

None

@rexxars rexxars requested a review from a team as a code owner February 5, 2025 01:28
@rexxars rexxars requested review from juice49 and removed request for a team February 5, 2025 01:28
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 1:36am
performance-studio ✅ Ready (Inspect) Visit Preview Feb 5, 2025 1:36am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 1:36am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 1:36am
test-next-studio ⬜️ Ignored (Inspect) Feb 5, 2025 1:36am

@rexxars rexxars force-pushed the fix/switch-diff-patch branch from 8369d52 to ecee845 Compare February 5, 2025 01:29
Copy link
Contributor

github-actions bot commented Feb 5, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Component Testing Report Updated Feb 5, 2025 1:40 AM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 14s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 20s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 30s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 2s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Feb 5, 2025

⚡️ Editor Performance Report

Updated Wed, 05 Feb 2025 01:42:39 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.5 efps (45ms) 23.3 efps (43ms) -2ms (-3.4%)
article (body) 77.8 efps (13ms) 78.1 efps (13ms) -0ms (-/-%)
article (string inside object) 25.0 efps (40ms) 24.4 efps (41ms) +1ms (+2.5%)
article (string inside array) 21.5 efps (47ms) 21.7 efps (46ms) -1ms (-1.1%)
recipe (name) 47.6 efps (21ms) 50.0 efps (20ms) -1ms (-4.8%)
recipe (description) 52.6 efps (19ms) 55.6 efps (18ms) -1ms (-5.3%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.8 efps (51ms) 19.4 efps (52ms) +1ms (+2.0%)
synthetic (string inside object) 19.6 efps (51ms) 20.2 efps (50ms) -2ms (-2.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 45ms 54ms 80ms 484ms 1020ms 11.4s
article (body) 13ms 15ms 18ms 94ms 202ms 5.2s
article (string inside object) 40ms 42ms 46ms 73ms 319ms 7.1s
article (string inside array) 47ms 48ms 50ms 240ms 450ms 7.6s
recipe (name) 21ms 23ms 25ms 36ms 0ms 7.0s
recipe (description) 19ms 20ms 22ms 59ms 0ms 4.6s
recipe (instructions) 5ms 6ms 8ms 18ms 0ms 3.0s
synthetic (title) 51ms 53ms 58ms 74ms 424ms 12.6s
synthetic (string inside object) 51ms 55ms 62ms 683ms 1561ms 9.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 45ms 49ms 373ms 287ms 10.6s
article (body) 13ms 15ms 19ms 67ms 193ms 4.9s
article (string inside object) 41ms 43ms 50ms 188ms 429ms 7.7s
article (string inside array) 46ms 47ms 54ms 150ms 296ms 7.3s
recipe (name) 20ms 22ms 26ms 44ms 0ms 7.1s
recipe (description) 18ms 19ms 21ms 30ms 0ms 4.6s
recipe (instructions) 5ms 6ms 14ms 31ms 0ms 3.2s
synthetic (title) 52ms 53ms 58ms 245ms 686ms 12.5s
synthetic (string inside object) 50ms 55ms 80ms 469ms 1242ms 8.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant