Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/core #8523

Draft
wants to merge 3 commits into
base: next
Choose a base branch
from
Draft

Feat/core #8523

wants to merge 3 commits into from

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Feb 6, 2025

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 1:34pm
performance-studio ✅ Ready (Inspect) Visit Preview Feb 10, 2025 1:34pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 1:34pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 1:34pm
test-next-studio ⬜️ Ignored (Inspect) Feb 10, 2025 1:34pm

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.44% 53803 / 126771
🔵 Statements 42.44% 53803 / 126771
🔵 Functions 47.94% 2772 / 5782
🔵 Branches 78.8% 10301 / 13072
File CoverageNo changed files found.
Generated in workflow #30080 for commit 4d53d7e by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Feb 6, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Component Testing Report Updated Feb 10, 2025 1:40 PM (UTC)

❌ Failed Tests (51) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ❌ Failed (Inspect) 39s 10 0 5
formBuilder/ArrayInput.spec.tsx ❌ Failed (Inspect) 7s 2 0 1
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 2m 19s 1 0 5
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ❌ Failed (Inspect) 51s 11 1 6
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ❌ Failed (Inspect) 15s 4 0 2
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ❌ Failed (Inspect) 9s 2 0 1
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ❌ Failed (Inspect) 16s 4 0 2
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ❌ Failed (Inspect) 40s 10 0 5
formBuilder/inputs/PortableText/Input.spec.tsx ❌ Failed (Inspect) 55s 14 0 7
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 1m 16s 14 0 7
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ❌ Failed (Inspect) 7s 2 9 1
formBuilder/inputs/PortableText/Styles.spec.tsx ❌ Failed (Inspect) 16s 4 0 2
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 1s 14 0 7
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Feb 6, 2025

⚡️ Editor Performance Report

Updated Mon, 10 Feb 2025 13:41:03 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 21.3 efps (47ms) 23.3 efps (43ms) -4ms (-8.5%)
article (body) 61.3 efps (16ms) 63.5 efps (16ms) -1ms (-3.4%)
article (string inside object) 23.3 efps (43ms) 25.3 efps (40ms) -4ms (-8.1%)
article (string inside array) 21.3 efps (47ms) 21.3 efps (47ms) +0ms (-/-%)
recipe (name) 50.0 efps (20ms) 48.8 efps (21ms) +1ms (+2.5%)
recipe (description) 52.6 efps (19ms) 55.6 efps (18ms) -1ms (-5.3%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 20.4 efps (49ms) 20.2 efps (50ms) +1ms (+1.0%)
synthetic (string inside object) 20.8 efps (48ms) 21.3 efps (47ms) -1ms (-2.1%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 47ms 59ms 83ms 350ms 578ms 13.1s
article (body) 16ms 18ms 31ms 237ms 496ms 6.0s
article (string inside object) 43ms 44ms 50ms 168ms 213ms 7.4s
article (string inside array) 47ms 51ms 60ms 260ms 632ms 8.1s
recipe (name) 20ms 22ms 27ms 42ms 0ms 7.1s
recipe (description) 19ms 21ms 24ms 36ms 0ms 4.6s
recipe (instructions) 5ms 7ms 8ms 18ms 0ms 3.1s
synthetic (title) 49ms 50ms 52ms 132ms 315ms 12.6s
synthetic (string inside object) 48ms 49ms 60ms 395ms 780ms 7.9s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 54ms 85ms 456ms 879ms 11.8s
article (body) 16ms 19ms 28ms 138ms 203ms 5.8s
article (string inside object) 40ms 44ms 45ms 234ms 282ms 7.1s
article (string inside array) 47ms 50ms 55ms 211ms 234ms 7.5s
recipe (name) 21ms 22ms 24ms 48ms 0ms 6.9s
recipe (description) 18ms 19ms 20ms 37ms 0ms 4.5s
recipe (instructions) 5ms 6ms 7ms 21ms 0ms 3.0s
synthetic (title) 50ms 52ms 59ms 394ms 787ms 12.8s
synthetic (string inside object) 47ms 51ms 59ms 101ms 650ms 7.9s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants