Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(releases): using publishedAt to present publish time for past releases #8553

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

jordanl17
Copy link
Member

@jordanl17 jordanl17 commented Feb 7, 2025

Description

Before:
An ASAP published release would just show 'Published'
Screenshot 2025-02-07 at 17 49 22

After:
ASAP published releases list the published at time
Screenshot 2025-02-07 at 17 50 58

Note

With the changes made to content lake, all published releases will have a publishedAt.

What to review

Testing

Updated existing tests

Notes for release

N/A

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:15pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:15pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 5:15pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 5:15pm
test-next-studio ⬜️ Ignored (Inspect) Feb 7, 2025 5:15pm

Copy link
Contributor

github-actions bot commented Feb 7, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.44% 53809 / 126779
🔵 Statements 42.44% 53809 / 126779
🔵 Functions 47.95% 2774 / 5784
🔵 Branches 78.83% 10321 / 13092
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/releases/__fixtures__/release.fixture.ts 100% 100% 100% 100%
packages/sanity/src/core/releases/hooks/useReleaseTime.ts 100% 100% 100% 100%
packages/sanity/src/core/releases/store/createReleaseStore.ts 88.88% 100% 66.66% 88.88% 89-90, 112-120
packages/sanity/src/core/releases/store/types.ts 100% 100% 100% 100%
packages/sanity/src/core/releases/tool/components/ReleaseTime.tsx 100% 100% 100% 100%
packages/sanity/src/core/releases/tool/detail/ReleaseTypePicker.tsx 87.22% 92.68% 100% 87.22% 77-88, 102-105, 118-119, 144-153, 199, 239-241
packages/sanity/src/core/releases/tool/overview/ReleasesOverviewColumnDefs.tsx 99.14% 92% 100% 99.14% 87
packages/sanity/src/core/releases/util/util.ts 95% 85% 85.71% 95% 35-36
Generated in workflow #30035 for commit 29c6568 by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Component Testing Report Updated Feb 10, 2025 2:57 PM (UTC)

❌ Failed Tests (1) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 22s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 20s 5 0 1
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 49s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 2m 3s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 44s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Feb 7, 2025

⚡️ Editor Performance Report

Updated Fri, 07 Feb 2025 17:21:10 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.6 efps (39ms) 26.3 efps (38ms) -1ms (-2.6%)
article (body) 72.2 efps (14ms) 72.5 efps (14ms) -0ms (-/-%)
article (string inside object) 26.0 efps (39ms) 27.8 efps (36ms) -3ms (-6.5%)
article (string inside array) 24.4 efps (41ms) 22.7 efps (44ms) +3ms (+7.3%)
recipe (name) 52.6 efps (19ms) 52.6 efps (19ms) +0ms (-/-%)
recipe (description) 58.8 efps (17ms) 62.5 efps (16ms) -1ms (-5.9%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.5 efps (54ms) 20.0 efps (50ms) -4ms (-7.4%)
synthetic (string inside object) 19.0 efps (53ms) 20.0 efps (50ms) -3ms (-4.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 39ms 45ms 55ms 246ms 384ms 10.9s
article (body) 14ms 16ms 22ms 210ms 309ms 5.7s
article (string inside object) 39ms 41ms 48ms 131ms 256ms 7.2s
article (string inside array) 41ms 44ms 49ms 134ms 361ms 7.2s
recipe (name) 19ms 21ms 23ms 55ms 0ms 7.4s
recipe (description) 17ms 18ms 20ms 36ms 0ms 4.4s
recipe (instructions) 5ms 6ms 7ms 22ms 0ms 3.0s
synthetic (title) 54ms 55ms 61ms 211ms 1077ms 13.2s
synthetic (string inside object) 53ms 55ms 60ms 411ms 1198ms 8.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 44ms 67ms 481ms 787ms 10.3s
article (body) 14ms 16ms 23ms 138ms 438ms 5.9s
article (string inside object) 36ms 38ms 43ms 64ms 110ms 6.4s
article (string inside array) 44ms 45ms 50ms 236ms 348ms 7.5s
recipe (name) 19ms 20ms 22ms 33ms 0ms 7.2s
recipe (description) 16ms 17ms 19ms 28ms 0ms 4.4s
recipe (instructions) 5ms 6ms 7ms 11ms 0ms 3.0s
synthetic (title) 50ms 54ms 87ms 252ms 746ms 12.5s
synthetic (string inside object) 50ms 53ms 56ms 383ms 901ms 8.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@jordanl17 jordanl17 added this pull request to the merge queue Feb 10, 2025
Merged via the queue into next with commit 595b8b8 Feb 10, 2025
64 checks passed
@jordanl17 jordanl17 deleted the feat/corel-390-use-publishedAt branch February 10, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants