-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CI): update playwright cache on CI consistently #8559
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No changes to documentation |
Coverage Report
File CoverageNo changed files found. |
Component Testing Report Updated Feb 10, 2025 11:13 AM (UTC) ❌ Failed Tests (2) -- expand for details
|
⚡️ Editor Performance ReportUpdated Mon, 10 Feb 2025 11:37:00 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thank you so much @stipsan! <3
Description
I got a strange error on the CI on another PR:

Turns out the
Cache Playwright Browsers for Playwright's Version
step is failing to restore the cache:It should be restoring the cache from
playwright-browsers-1.50.1
, but it's falling back to some previous cache step that had an emptyPLAYWRIGHT_VERSION
env var.This issue started appearing after #8552 merged. This PR changes it so that the playwright version is stored with the GitHub output API instead of an intermediary env var.
It also shifts the cache key to
${version}-playwright-browsers
. That way, if1.50.1-playwright-browsers
has no match, github will look at these as fallbacks:Instead of the current behavior of:
Which isn't what we want.
What to review
Makes sense?
Testing
If builds pass we're good. Although I don't think the
playwright-ct-test (webkit, 1, 2)
andplaywright-ct-test (webkit, 2, 2)
jobs will pass, as they didn't for #8552 which bumped playwright to 1.50.1. (test 1, test 2)Notes for release
N/A