Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): dedupe pnpm-lock.yaml #8564

Merged
merged 1 commit into from
Feb 10, 2025
Merged

chore(deps): dedupe pnpm-lock.yaml #8564

merged 1 commit into from
Feb 10, 2025

Conversation

ecospark[bot]
Copy link
Contributor

@ecospark ecospark bot commented Feb 10, 2025

I ran pnpm dedupe 🧑‍💻

@ecospark ecospark bot requested a review from a team as a code owner February 10, 2025 11:28
@ecospark ecospark bot added the 🤖 bot label Feb 10, 2025
@ecospark ecospark bot requested review from juice49 and removed request for a team February 10, 2025 11:28
@vercel Vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 11:44am
performance-studio ✅ Ready (Inspect) Visit Preview Feb 10, 2025 11:44am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 11:44am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 11:44am
test-next-studio ⬜️ Ignored (Inspect) Feb 10, 2025 11:44am

@socket-security Socket Security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected]

View full report↗︎

@stipsan stipsan enabled auto-merge February 10, 2025 11:32
@stipsan stipsan added this pull request to the merge queue Feb 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

Merged via the queue into next with commit a776512 Feb 10, 2025
36 of 41 checks passed
@stipsan stipsan deleted the actions/dedupe-if-needed branch February 10, 2025 11:33
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.44% 53803 / 126771
🔵 Statements 42.44% 53803 / 126771
🔵 Functions 47.94% 2772 / 5782
🔵 Branches 78.82% 10316 / 13087
File CoverageNo changed files found.
Generated in workflow #30059 for commit 64ba38f by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

Component Testing Report Updated Feb 10, 2025 11:40 AM (UTC)

❌ Failed Tests (52) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ❌ Failed (Inspect) 39s 10 0 5
formBuilder/ArrayInput.spec.tsx ❌ Failed (Inspect) 7s 2 0 1
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 2m 58s 0 0 6
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ❌ Failed (Inspect) 51s 11 1 6
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ❌ Failed (Inspect) 16s 4 0 2
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ❌ Failed (Inspect) 8s 2 0 1
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ❌ Failed (Inspect) 16s 4 0 2
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ❌ Failed (Inspect) 40s 10 0 5
formBuilder/inputs/PortableText/Input.spec.tsx ❌ Failed (Inspect) 57s 14 0 7
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 1m 19s 14 0 7
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ❌ Failed (Inspect) 8s 2 9 1
formBuilder/inputs/PortableText/Styles.spec.tsx ❌ Failed (Inspect) 16s 4 0 2
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 2s 14 0 7
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@github-actions GitHub Actions
Copy link
Contributor

⚡️ Editor Performance Report

Updated Mon, 10 Feb 2025 11:44:20 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 24.4 efps (41ms) 27.0 efps (37ms) -4ms (-9.8%) ✅
article (body) 69.9 efps (14ms) 73.0 efps (14ms) -1ms (-/-%) ✅
article (string inside object) 25.6 efps (39ms) 27.4 efps (37ms) -3ms (-6.4%) ✅
article (string inside array) 22.2 efps (45ms) 25.0 efps (40ms) -5ms (-11.1%) ✅
synthetic (title) 20.4 efps (49ms) 20.2 efps (50ms) +1ms (+1.0%) ✅
synthetic (string inside object) 20.8 efps (48ms) 20.4 efps (49ms) +1ms (+2.1%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 45ms 51ms 411ms 216ms 11.6s
article (body) 14ms 17ms 22ms 286ms 282ms 5.4s
article (string inside object) 39ms 41ms 43ms 150ms 146ms 7.0s
article (string inside array) 45ms 46ms 53ms 73ms 254ms 7.2s
synthetic (title) 49ms 51ms 58ms 287ms 952ms 13.3s
synthetic (string inside object) 48ms 52ms 61ms 500ms 915ms 8.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 44ms 62ms 341ms 771ms 10.0s
article (body) 14ms 16ms 22ms 96ms 177ms 5.1s
article (string inside object) 37ms 40ms 61ms 170ms 393ms 6.9s
article (string inside array) 40ms 41ms 50ms 154ms 339ms 7.1s
synthetic (title) 50ms 53ms 67ms 305ms 1078ms 13.1s
synthetic (string inside object) 49ms 51ms 64ms 418ms 904ms 8.2s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

juice49 pushed a commit that referenced this pull request Feb 11, 2025
@ecospark @juice49
chore(deps): dedupe pnpm-lock.yaml (#8564)
20da5c2 
Co-authored-by: ecospark[bot] <128108030+ecospark[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stipsan stipsan stipsan approved these changes

@juice49 juice49 Awaiting requested review from juice49 juice49 is a code owner automatically assigned from sanity-io/studio

Assignees
No one assigned
Labels
🤖 bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stipsan