You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the messages so that it'll show schedule if it's a release can can be scheduled or publish if it's a release that can be published
This is a more naive way of handling these errors without taking into account spceifically the error messages that come from the backend, however, it should be enough for now. If it needs a finer touch we can come back and adjust accordingly. A story has been created as a follow up.
What to review
Do you agree with my assessment? The code?
Testing
Existing tests should be fine
Notes for release
Update translations for error messages in releases.
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
35ms
39ms
45ms
104ms
171ms
11.0s
article (body)
14ms
15ms
24ms
158ms
275ms
5.1s
article (string inside object)
36ms
40ms
53ms
230ms
245ms
6.9s
article (string inside array)
40ms
44ms
47ms
185ms
313ms
6.9s
recipe (name)
19ms
21ms
24ms
53ms
0ms
7.6s
recipe (description)
17ms
17ms
19ms
36ms
0ms
4.4s
recipe (instructions)
5ms
6ms
7ms
19ms
0ms
3.0s
synthetic (title)
51ms
54ms
60ms
263ms
926ms
14.5s
synthetic (string inside object)
52ms
53ms
57ms
264ms
928ms
8.4s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
37ms
40ms
53ms
133ms
196ms
10.8s
article (body)
13ms
15ms
20ms
150ms
201ms
4.8s
article (string inside object)
37ms
39ms
44ms
129ms
293ms
7.0s
article (string inside array)
40ms
43ms
52ms
162ms
315ms
7.1s
recipe (name)
19ms
20ms
27ms
48ms
0ms
7.4s
recipe (description)
16ms
17ms
18ms
26ms
0ms
4.3s
recipe (instructions)
5ms
6ms
8ms
16ms
0ms
3.0s
synthetic (title)
46ms
53ms
66ms
376ms
1238ms
13.5s
synthetic (string inside object)
49ms
52ms
84ms
258ms
539ms
7.7s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the messages so that it'll show schedule if it's a release can can be scheduled or publish if it's a release that can be published
This is a more naive way of handling these errors without taking into account spceifically the error messages that come from the backend, however, it should be enough for now. If it needs a finer touch we can come back and adjust accordingly. A story has been created as a follow up.
What to review
Do you agree with my assessment? The code?
Testing
Existing tests should be fine
Notes for release
Update translations for error messages in releases.