Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): update message to be schedule or publish error #8569

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

RitaDias
Copy link
Contributor

Description

Change the messages so that it'll show schedule if it's a release can can be scheduled or publish if it's a release that can be published

This is a more naive way of handling these errors without taking into account spceifically the error messages that come from the backend, however, it should be enough for now. If it needs a finer touch we can come back and adjust accordingly. A story has been created as a follow up.

What to review

Do you agree with my assessment? The code?

Testing

Existing tests should be fine

Notes for release

Update translations for error messages in releases.

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 0:58am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 0:58am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 0:58am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 10, 2025 0:58am
test-next-studio ⬜️ Ignored (Inspect) Feb 10, 2025 0:58am

@RitaDias RitaDias marked this pull request as ready for review February 10, 2025 12:58
@RitaDias RitaDias requested a review from a team as a code owner February 10, 2025 12:58
@RitaDias RitaDias requested a review from bjoerge February 10, 2025 12:58
Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.44% 53809 / 126779
🔵 Statements 42.44% 53809 / 126779
🔵 Functions 47.94% 2772 / 5782
🔵 Branches 78.8% 10312 / 13085
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/releases/i18n/resources.ts 100% 100% 100% 100%
packages/sanity/src/core/releases/tool/detail/ReleaseDashboardDetails.tsx 93.9% 30.76% 50% 93.9% 40-43, 71, 89
Generated in workflow #30078 for commit 8326e1a by the Vitest Coverage Report Action

Copy link
Contributor

github-actions bot commented Feb 10, 2025

⚡️ Editor Performance Report

Updated Mon, 10 Feb 2025 14:21:53 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 28.6 efps (35ms) 27.4 efps (37ms) +2ms (+4.3%)
article (body) 72.5 efps (14ms) 77.5 efps (13ms) -1ms (-/-%)
article (string inside object) 27.8 efps (36ms) 27.0 efps (37ms) +1ms (+2.8%)
article (string inside array) 25.0 efps (40ms) 25.0 efps (40ms) +0ms (-/-%)
recipe (name) 52.6 efps (19ms) 52.6 efps (19ms) +0ms (-/-%)
recipe (description) 60.6 efps (17ms) 62.5 efps (16ms) -1ms (-3.0%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.6 efps (51ms) 21.7 efps (46ms) -5ms (-9.8%)
synthetic (string inside object) 19.4 efps (52ms) 20.4 efps (49ms) -3ms (-4.9%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 35ms 39ms 45ms 104ms 171ms 11.0s
article (body) 14ms 15ms 24ms 158ms 275ms 5.1s
article (string inside object) 36ms 40ms 53ms 230ms 245ms 6.9s
article (string inside array) 40ms 44ms 47ms 185ms 313ms 6.9s
recipe (name) 19ms 21ms 24ms 53ms 0ms 7.6s
recipe (description) 17ms 17ms 19ms 36ms 0ms 4.4s
recipe (instructions) 5ms 6ms 7ms 19ms 0ms 3.0s
synthetic (title) 51ms 54ms 60ms 263ms 926ms 14.5s
synthetic (string inside object) 52ms 53ms 57ms 264ms 928ms 8.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 40ms 53ms 133ms 196ms 10.8s
article (body) 13ms 15ms 20ms 150ms 201ms 4.8s
article (string inside object) 37ms 39ms 44ms 129ms 293ms 7.0s
article (string inside array) 40ms 43ms 52ms 162ms 315ms 7.1s
recipe (name) 19ms 20ms 27ms 48ms 0ms 7.4s
recipe (description) 16ms 17ms 18ms 26ms 0ms 4.3s
recipe (instructions) 5ms 6ms 8ms 16ms 0ms 3.0s
synthetic (title) 46ms 53ms 66ms 376ms 1238ms 13.5s
synthetic (string inside object) 49ms 52ms 84ms 258ms 539ms 7.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Component Testing Report Updated Feb 10, 2025 2:41 PM (UTC)

❌ Failed Tests (50) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ❌ Failed (Inspect) 40s 10 0 5
formBuilder/ArrayInput.spec.tsx ❌ Failed (Inspect) 7s 2 0 1
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 42s 2 0 4
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ❌ Failed (Inspect) 52s 11 1 6
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ❌ Failed (Inspect) 16s 4 0 2
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ❌ Failed (Inspect) 9s 2 0 1
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ❌ Failed (Inspect) 16s 4 0 2
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ❌ Failed (Inspect) 40s 10 0 5
formBuilder/inputs/PortableText/Input.spec.tsx ❌ Failed (Inspect) 54s 14 0 7
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 1m 15s 14 0 7
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ❌ Failed (Inspect) 7s 2 9 1
formBuilder/inputs/PortableText/Styles.spec.tsx ❌ Failed (Inspect) 15s 4 0 2
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 1s 14 0 7
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@RitaDias RitaDias added this pull request to the merge queue Feb 10, 2025
Merged via the queue into next with commit 2ba4b9d Feb 10, 2025
57 of 60 checks passed
@RitaDias RitaDias deleted the sapp-2070 branch February 10, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants