Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Cli/server side schemas #8570

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from
Draft

Conversation

EsaNuurtamo
Copy link

@EsaNuurtamo EsaNuurtamo commented Feb 10, 2025

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 1:50pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 1:50pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 1:50pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Feb 10, 2025 1:50pm
test-next-studio ⬜️ Ignored (Inspect) Feb 10, 2025 1:50pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Feb 10, 2025 1:56 PM (UTC)

❌ Failed Tests (50) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ❌ Failed (Inspect) 40s 10 0 5
formBuilder/ArrayInput.spec.tsx ❌ Failed (Inspect) 8s 2 0 1
formBuilder/inputs/PortableText/Annotations.spec.tsx ❌ Failed (Inspect) 1m 42s 2 0 4
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ❌ Failed (Inspect) 53s 11 1 6
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ❌ Failed (Inspect) 16s 4 0 2
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ❌ Failed (Inspect) 8s 2 0 1
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ❌ Failed (Inspect) 16s 4 0 2
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ❌ Failed (Inspect) 40s 10 0 5
formBuilder/inputs/PortableText/Input.spec.tsx ❌ Failed (Inspect) 55s 14 0 7
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ❌ Failed (Inspect) 1m 15s 14 0 7
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ❌ Failed (Inspect) 7s 2 9 1
formBuilder/inputs/PortableText/Styles.spec.tsx ❌ Failed (Inspect) 15s 4 0 2
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 0s 14 0 7
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Mon, 10 Feb 2025 13:56:45 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 25.0 efps (40ms) 27.0 efps (37ms) -3ms (-7.5%)
article (body) 67.6 efps (15ms) 78.1 efps (13ms) -2ms (-/-%)
article (string inside object) 28.6 efps (35ms) 27.0 efps (37ms) +2ms (+5.7%)
article (string inside array) 25.6 efps (39ms) 25.0 efps (40ms) +1ms (+2.6%)
recipe (name) 51.3 efps (20ms) 52.6 efps (19ms) -1ms (-2.6%)
recipe (description) 50.0 efps (20ms) 62.5 efps (16ms) -4ms (-20.0%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 20.8 efps (48ms) 20.8 efps (48ms) +0ms (-/-%)
synthetic (string inside object) 20.8 efps (48ms) 20.4 efps (49ms) +1ms (+2.1%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 44ms 69ms 452ms 278ms 12.5s
article (body) 15ms 16ms 22ms 87ms 78ms 4.9s
article (string inside object) 35ms 37ms 42ms 74ms 140ms 6.2s
article (string inside array) 39ms 42ms 45ms 290ms 208ms 6.8s
recipe (name) 20ms 21ms 26ms 40ms 0ms 7.5s
recipe (description) 20ms 23ms 26ms 48ms 0ms 4.7s
recipe (instructions) 5ms 7ms 8ms 26ms 0ms 3.1s
synthetic (title) 48ms 50ms 54ms 216ms 559ms 12.8s
synthetic (string inside object) 48ms 52ms 60ms 517ms 948ms 8.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 42ms 44ms 427ms 141ms 11.5s
article (body) 13ms 14ms 19ms 40ms 62ms 4.8s
article (string inside object) 37ms 42ms 48ms 216ms 223ms 6.9s
article (string inside array) 40ms 41ms 46ms 55ms 135ms 6.8s
recipe (name) 19ms 21ms 23ms 49ms 0ms 6.8s
recipe (description) 16ms 17ms 17ms 26ms 0ms 4.3s
recipe (instructions) 5ms 6ms 7ms 9ms 0ms 3.0s
synthetic (title) 48ms 53ms 68ms 356ms 936ms 13.0s
synthetic (string inside object) 49ms 51ms 53ms 237ms 695ms 8.8s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant