fix(core): incorrect status indicator color for undecided releases #8571

pedrobonamin · 2025-02-10T14:16:32Z

Description

The color explore doesn't exist anymore, this updates it to use the correct color

Broken 😢	fixed 😄

What to review

Testing

Notes for release

vercel · 2025-02-10T14:16:36Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 10, 2025 4:09pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 10, 2025 4:09pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 10, 2025 4:09pm

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Feb 10, 2025 4:09pm
test-next-studio	⬜️ Ignored (Inspect)			Feb 10, 2025 4:09pm

github-actions · 2025-02-10T14:21:00Z

No changes to documentation

github-actions · 2025-02-10T14:22:17Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.43%	53726 / 126621
🔵	Statements	42.43%	53726 / 126621
🔵	Functions	47.91%	2767 / 5775
🔵	Branches	78.77%	10284 / 13055

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/sanity/src/core/components/documentStatusIndicator/DocumentStatusIndicator.tsx	16.27%	100%	0%	16.27%	49-92

Generated in workflow #30089 for commit a28d1dc by the Vitest Coverage Report Action

github-actions · 2025-02-10T14:26:41Z

Component Testing Report Updated Feb 10, 2025 4:26 PM (UTC)

❌ Failed Tests (3) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 9s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	12s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	❌ Failed (Inspect)	2m 35s	3	0	3
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	52s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	26s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	15s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 7s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 33s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	2m 5s	21	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	13s	3	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	26s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 44s	21	0	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

github-actions · 2025-02-10T14:30:44Z

⚡️ Editor Performance Report

Updated Mon, 10 Feb 2025 16:14:19 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	24.4 efps (41ms)	27.8 efps (36ms)	-5ms (-12.2%)	✅
article (body)	68.0 efps (15ms)	77.5 efps (13ms)	-2ms (-/-%)	✅
article (string inside object)	26.3 efps (38ms)	28.6 efps (35ms)	-3ms (-7.9%)	✅
article (string inside array)	23.3 efps (43ms)	25.0 efps (40ms)	-3ms (-7.0%)	✅
recipe (name)	52.6 efps (19ms)	52.6 efps (19ms)	+0ms (-/-%)	✅
recipe (description)	58.8 efps (17ms)	58.8 efps (17ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	20.6 efps (49ms)	20.8 efps (48ms)	-1ms (-1.0%)	✅
synthetic (string inside object)	19.6 efps (51ms)	20.0 efps (50ms)	-1ms (-2.0%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	41ms	47ms	80ms	350ms	589ms	11.1s
article (body)	15ms	16ms	19ms	132ms	219ms	5.5s
article (string inside object)	38ms	40ms	43ms	149ms	235ms	7.1s
article (string inside array)	43ms	46ms	49ms	222ms	180ms	7.4s
recipe (name)	19ms	21ms	25ms	45ms	0ms	7.3s
recipe (description)	17ms	19ms	21ms	28ms	0ms	4.5s
recipe (instructions)	5ms	7ms	10ms	32ms	0ms	3.1s
synthetic (title)	49ms	53ms	61ms	220ms	533ms	13.2s
synthetic (string inside object)	51ms	53ms	56ms	320ms	577ms	7.9s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	36ms	44ms	60ms	253ms	889ms	10.4s
article (body)	13ms	14ms	18ms	87ms	183ms	4.8s
article (string inside object)	35ms	39ms	43ms	186ms	304ms	6.9s
article (string inside array)	40ms	44ms	47ms	172ms	330ms	7.0s
recipe (name)	19ms	20ms	22ms	56ms	0ms	7.2s
recipe (description)	17ms	18ms	22ms	33ms	0ms	4.4s
recipe (instructions)	5ms	7ms	8ms	18ms	0ms	3.1s
synthetic (title)	48ms	51ms	55ms	437ms	882ms	13.9s
synthetic (string inside object)	50ms	54ms	68ms	123ms	665ms	8.0s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

…8571)

pedrobonamin requested a review from a team as a code owner February 10, 2025 14:16

pedrobonamin requested review from ryanbonial and removed request for a team February 10, 2025 14:16

pedrobonamin requested review from a team and jordanl17 and removed request for ryanbonial February 10, 2025 14:16

vercel bot deployed to Preview – page-building-studio February 10, 2025 14:20 View deployment

vercel bot deployed to Preview – performance-studio February 10, 2025 14:21 View deployment

vercel bot deployed to Preview – test-studio February 10, 2025 14:21 View deployment

bjoerge approved these changes Feb 10, 2025

View reviewed changes

fix(core): incorrect status indicator color for undecided releases

a28d1dc

pedrobonamin force-pushed the fix-status-indicator branch from 13dcb86 to a28d1dc Compare February 10, 2025 16:01

vercel bot deployed to Preview – page-building-studio February 10, 2025 16:08 View deployment

vercel bot deployed to Preview – performance-studio February 10, 2025 16:08 View deployment

vercel bot deployed to Preview – test-studio February 10, 2025 16:09 View deployment

jordanl17 approved these changes Feb 10, 2025

View reviewed changes

pedrobonamin added this pull request to the merge queue Feb 10, 2025

Merged via the queue into next with commit 19d1bc3 Feb 10, 2025
63 checks passed

github-merge-queue bot pushed a commit that referenced this pull request Feb 10, 2025

fix(core): incorrect status indicator color for undecided releases (#…

19d1bc3

…8571)

pedrobonamin deleted the fix-status-indicator branch February 10, 2025 17:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): incorrect status indicator color for undecided releases #8571

fix(core): incorrect status indicator color for undecided releases #8571

pedrobonamin commented Feb 10, 2025

vercel bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

fix(core): incorrect status indicator color for undecided releases #8571

fix(core): incorrect status indicator color for undecided releases #8571

Conversation

pedrobonamin commented Feb 10, 2025

Description

What to review

Testing

Notes for release

vercel bot commented Feb 10, 2025 • edited Loading

github-actions bot commented Feb 10, 2025

github-actions bot commented Feb 10, 2025 • edited Loading

Coverage Report

github-actions bot commented Feb 10, 2025 • edited Loading

github-actions bot commented Feb 10, 2025 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

vercel bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading

github-actions bot commented Feb 10, 2025 •

edited

Loading