Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sanity): hide global user menu inside Core UI Rendering Context #8591

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

juice49
Copy link
Contributor

@juice49 juice49 commented Feb 11, 2025

Description

This branch removes the global user menu when Studio is rendered inside Core UI. Core UI provides the global user menu capability, so Studio doesn't need to.

Small viewport

Screenshot 2025-03-06 at 12 40 31

Large viewport

Screenshot 2025-03-06 at 12 40 40

What to review

The removal of the global user menu.

Testing

This can be tested by running Studio locally and then accessing the local dev server using a Core UI preview deployment.

Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 5:29pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 5:29pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 5:29pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2025 5:29pm
test-next-studio ⬜️ Ignored (Inspect) Mar 6, 2025 5:29pm

Copy link
Contributor Author

juice49 commented Feb 11, 2025

@juice49 juice49 force-pushed the feat/sapp-2363/studio-rendering-context branch from 460ed9a to 2e92148 Compare February 11, 2025 14:57
Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Feb 11, 2025

⚡️ Editor Performance Report

Updated Thu, 06 Mar 2025 17:41:22 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.3 efps (43ms) 24.4 efps (41ms) -2ms (-4.7%)
article (body) 69.9 efps (14ms) 84.4 efps (12ms) -2ms (-/-%)
article (string inside object) 22.7 efps (44ms) 26.0 efps (39ms) -6ms (-12.5%)
article (string inside array) 21.3 efps (47ms) 24.1 efps (42ms) -6ms (-11.7%)
recipe (name) 47.6 efps (21ms) 45.5 efps (22ms) +1ms (+4.8%)
recipe (description) 52.6 efps (19ms) 47.6 efps (21ms) +2ms (+10.5%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 19.6 efps (51ms) 18.9 efps (53ms) +2ms (+3.9%)
synthetic (string inside object) 19.6 efps (51ms) 19.6 efps (51ms) +0ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 43ms 47ms 54ms 305ms 347ms 11.2s
article (body) 14ms 16ms 21ms 234ms 350ms 5.5s
article (string inside object) 44ms 47ms 50ms 302ms 458ms 7.5s
article (string inside array) 47ms 49ms 51ms 81ms 210ms 7.5s
recipe (name) 21ms 23ms 25ms 45ms 0ms 7.4s
recipe (description) 19ms 22ms 23ms 47ms 0ms 4.7s
recipe (instructions) 5ms 6ms 7ms 8ms 0ms 3.1s
synthetic (title) 51ms 54ms 59ms 213ms 680ms 12.1s
synthetic (string inside object) 51ms 56ms 63ms 78ms 461ms 7.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 58ms 70ms 272ms 408ms 9.8s
article (body) 12ms 15ms 16ms 40ms 51ms 4.8s
article (string inside object) 39ms 41ms 46ms 98ms 174ms 6.8s
article (string inside array) 42ms 44ms 46ms 49ms 23ms 6.7s
recipe (name) 22ms 24ms 30ms 48ms 4ms 7.6s
recipe (description) 21ms 23ms 26ms 101ms 0ms 5.1s
recipe (instructions) 5ms 6ms 7ms 9ms 0ms 3.1s
synthetic (title) 53ms 55ms 58ms 246ms 736ms 12.4s
synthetic (string inside object) 51ms 52ms 62ms 127ms 631ms 7.7s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Component Testing Report Updated Mar 6, 2025 5:43 PM (UTC)

❌ Failed Tests (2) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 4s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 35s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 46s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ❌ Failed (Inspect) 1m 49s 14 0 1
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 28s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 46s 21 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 12s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 2m 14s 20 0 1
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@juice49 juice49 changed the base branch from feat/sapp-2363/studio-rendering-context to graphite-base/8591 February 12, 2025 23:01
@juice49 juice49 force-pushed the feat/sapp-2035/core-ui-hide-user-menu branch from d0546ef to 3363ff9 Compare February 12, 2025 23:01
@juice49 juice49 changed the base branch from graphite-base/8591 to feat/sapp-2363/studio-rendering-content-capability-gate February 12, 2025 23:01
@juice49 juice49 force-pushed the feat/sapp-2035/core-ui-hide-user-menu branch from 3363ff9 to 8d1981c Compare February 12, 2025 23:09
@juice49 juice49 force-pushed the feat/sapp-2035/core-ui-hide-user-menu branch from 8d1981c to b021b5f Compare March 3, 2025 11:35
@juice49 juice49 force-pushed the feat/sapp-2363/studio-rendering-content-capability-gate branch from e23ed66 to f6ea950 Compare March 3, 2025 11:35
@juice49 juice49 force-pushed the feat/sapp-2035/core-ui-hide-user-menu branch from b021b5f to 837940b Compare March 4, 2025 22:30
@juice49 juice49 force-pushed the feat/sapp-2363/studio-rendering-content-capability-gate branch from f6ea950 to f4321f9 Compare March 4, 2025 22:30
@juice49 juice49 requested review from rexxars and RitaDias and removed request for rexxars March 6, 2025 12:42
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 42.03% 54351 / 129294
🔵 Statements 42.03% 54351 / 129294
🔵 Functions 46.93% 2729 / 5815
🔵 Branches 79.41% 10181 / 12820
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/sanity/src/core/studio/components/navbar/StudioNavbar.tsx 16.42% 100% 0% 16.42% 69-310
packages/sanity/src/core/studio/components/navbar/navDrawer/NavDrawer.tsx 26.74% 100% 0% 26.74% 85-245
Generated in workflow #31822 for commit 42720eb by the Vitest Coverage Report Action

jordanl17
jordanl17 previously approved these changes Mar 6, 2025
RitaDias
RitaDias previously approved these changes Mar 6, 2025
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! ✅

@juice49 juice49 force-pushed the feat/sapp-2363/studio-rendering-content-capability-gate branch 2 times, most recently from 34943ef to 0a6f7ba Compare March 6, 2025 15:51
@juice49 juice49 force-pushed the feat/sapp-2035/core-ui-hide-user-menu branch from f94906f to f5ba45a Compare March 6, 2025 15:51
@juice49 juice49 changed the base branch from feat/sapp-2363/studio-rendering-content-capability-gate to graphite-base/8591 March 6, 2025 16:56
@juice49 juice49 force-pushed the graphite-base/8591 branch from 0a6f7ba to 5b06c42 Compare March 6, 2025 17:21
@juice49 juice49 force-pushed the feat/sapp-2035/core-ui-hide-user-menu branch from f5ba45a to 42720eb Compare March 6, 2025 17:21
@juice49 juice49 changed the base branch from graphite-base/8591 to next March 6, 2025 17:22
@juice49 juice49 dismissed stale reviews from RitaDias and jordanl17 March 6, 2025 17:22

The base branch was changed.

Copy link

graphite-app bot commented Mar 6, 2025

Merge activity

  • Mar 6, 12:22 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Mar 6, 12:42 PM EST: A user merged this pull request with Graphite.

@juice49 juice49 requested a review from jordanl17 March 6, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants