fix(core): add permissions limitation to document actions in releases #8603

RitaDias · 2025-02-12T08:47:02Z

Description

Add disable action when user doesn't have permission to discard version in document action and in the release detail table
Add disable action when user doesn't have permission to unpublish document in the release detail table
Update document action to new action
Permissions there now use the versions
Updated tooltip text for different conditions on the unpublish action

Screen.Recording.2025-02-12.at.09.45.20.mov

What to review

Does everything look alright?

Testing

Didn't add tests to the menu actions since the larger changes happened directly in the permission aspect of things
To manually test you should use a user that doesn't have permissions (viewer), the debug roles don't work consistently.

Notes for release

Document actions (discard version and unpublish) in a release now respect permissions

…ctions

vercel · 2025-02-12T08:47:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 12, 2025 0:54am
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 12, 2025 0:54am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 12, 2025 0:54am

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Feb 12, 2025 0:54am
test-next-studio	⬜️ Ignored (Inspect)			Feb 12, 2025 0:54am

github-actions · 2025-02-12T08:52:30Z

No changes to documentation

github-actions · 2025-02-12T08:52:56Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	42.58%	53945 / 126664
🔵	Statements	42.58%	53945 / 126664
🔵	Functions	48.04%	2778 / 5782
🔵	Branches	78.82%	10356 / 13138

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/sanity/src/core/releases/i18n/resources.ts	100%	100%	100%	100%
packages/sanity/src/core/releases/plugin/documentActions/DiscardVersionAction.tsx	16.32%	100%	0%	16.32%	18-67
packages/sanity/src/core/releases/tool/detail/documentTable/DocumentActions.tsx	93.1%	92.85%	40%	93.1%	57, 60, 113-116
packages/sanity/src/core/store/_legacy/grants/documentPairPermissions.ts	70.58%	52.77%	100%	70.58%	26-27, 65-75, 78-81, 90-106, 128-140, 143-158, 161-162, 213-214, 258-261

Generated in workflow #30252 for commit e23427c by the Vitest Coverage Report Action

github-actions · 2025-02-12T09:00:29Z

⚡️ Editor Performance Report

Updated Wed, 12 Feb 2025 13:00:04 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	25.6 efps (39ms)	27.0 efps (37ms)	-2ms (-5.1%)	✅
article (body)	72.7 efps (14ms)	72.5 efps (14ms)	+0ms (-/-%)	✅
article (string inside object)	27.8 efps (36ms)	27.0 efps (37ms)	+1ms (+2.8%)	✅
article (string inside array)	23.8 efps (42ms)	23.8 efps (42ms)	+0ms (-/-%)	✅
recipe (name)	51.3 efps (20ms)	51.3 efps (20ms)	+0ms (-/-%)	✅
recipe (description)	58.8 efps (17ms)	58.8 efps (17ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	21.1 efps (48ms)	20.4 efps (49ms)	+2ms (+3.2%)	✅
synthetic (string inside object)	20.4 efps (49ms)	20.8 efps (48ms)	-1ms (-2.0%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	39ms	41ms	46ms	104ms	69ms	11.4s
article (body)	14ms	16ms	18ms	114ms	88ms	5.1s
article (string inside object)	36ms	38ms	45ms	157ms	126ms	6.4s
article (string inside array)	42ms	45ms	51ms	153ms	332ms	7.3s
recipe (name)	20ms	21ms	24ms	48ms	4ms	7.2s
recipe (description)	17ms	18ms	20ms	30ms	0ms	4.5s
recipe (instructions)	5ms	7ms	8ms	9ms	0ms	3.1s
synthetic (title)	48ms	54ms	58ms	495ms	917ms	12.8s
synthetic (string inside object)	49ms	52ms	65ms	456ms	907ms	8.5s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	37ms	40ms	42ms	307ms	11ms	10.0s
article (body)	14ms	16ms	20ms	161ms	199ms	5.2s
article (string inside object)	37ms	40ms	45ms	171ms	349ms	7.1s
article (string inside array)	42ms	44ms	47ms	74ms	245ms	6.8s
recipe (name)	20ms	21ms	24ms	34ms	0ms	7.3s
recipe (description)	17ms	18ms	19ms	20ms	0ms	4.4s
recipe (instructions)	5ms	6ms	7ms	19ms	0ms	3.1s
synthetic (title)	49ms	51ms	54ms	68ms	267ms	12.1s
synthetic (string inside object)	48ms	49ms	50ms	54ms	210ms	7.1s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

github-actions · 2025-02-12T09:10:35Z

Component Testing Report Updated Feb 12, 2025 1:02 PM (UTC)

❌ Failed Tests (3) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 10s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	12s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	❌ Failed (Inspect)	2m 35s	3	0	3
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	53s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	26s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	15s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 8s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 35s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	2m 4s	21	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	13s	3	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	27s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 46s	21	0	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

bjoerge

Great work, thank you @RitaDias!

RitaDias added 4 commits February 11, 2025 14:11

fix(core): update documentPairPermission to allow for versions

76b7b11

fix(core): add disable when discarding version from the document footer

53227b1

fix(core): add permissions limitation to discard version in documentA…

86fdeaf

…ctions

fix(core): add permissions limitation to unpublishing in documentActions

7dd37c1

vercel bot deployed to Preview – performance-studio February 12, 2025 08:50 View deployment

vercel bot deployed to Preview – page-building-studio February 12, 2025 08:50 View deployment

vercel bot deployed to Preview – test-studio February 12, 2025 08:50 View deployment

RitaDias marked this pull request as ready for review February 12, 2025 09:29

RitaDias requested review from a team as code owners February 12, 2025 09:29

RitaDias requested a review from bjoerge February 12, 2025 09:29

Merge branch 'next' into sapp-2366

e23427c

vercel bot deployed to Preview – page-building-studio February 12, 2025 12:54 View deployment

vercel bot deployed to Preview – performance-studio February 12, 2025 12:54 View deployment

vercel bot deployed to Preview – test-studio February 12, 2025 12:54 View deployment

bjoerge approved these changes Feb 12, 2025

View reviewed changes

RitaDias enabled auto-merge (squash) February 12, 2025 13:49

stipsan disabled auto-merge February 12, 2025 13:57

stipsan merged commit 2706f6f into next Feb 12, 2025
62 checks passed

stipsan deleted the sapp-2366 branch February 12, 2025 14:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): add permissions limitation to document actions in releases #8603

fix(core): add permissions limitation to document actions in releases #8603

RitaDias commented Feb 12, 2025 •

edited

Loading

vercel bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

github-actions bot commented Feb 12, 2025 •

edited

Loading

bjoerge left a comment

fix(core): add permissions limitation to document actions in releases #8603

fix(core): add permissions limitation to document actions in releases #8603

Conversation

RitaDias commented Feb 12, 2025 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Feb 12, 2025 • edited Loading

github-actions bot commented Feb 12, 2025

github-actions bot commented Feb 12, 2025 • edited Loading

Coverage Report

github-actions bot commented Feb 12, 2025 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

github-actions bot commented Feb 12, 2025 • edited Loading

bjoerge left a comment

Choose a reason for hiding this comment

RitaDias commented Feb 12, 2025 •

edited

Loading

vercel bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading