fix(sanity): allow discovery of all document versions using groq2024 search #8775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
juice49
force-pushed
the
fix/groq-2024-search-versions
branch
from
f8dbf32 to
a80672c
Compare
juice49
changed the title
|
No changes to documentation |
|
Component Testing Report Updated Mar 6, 2025 4:04 PM (UTC) ❌ Failed Tests (3) -- expand for details
|
⚡️ Editor Performance ReportUpdated Thu, 06 Mar 2025 16:02:57 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
juice49
force-pushed
the
fix/groq-2024-search-versions
branch
from
a80672c to
3be2dc4
Compare
juice49
added a commit
that referenced
this pull request
Feb 27, 2025
The document collator currently inadvertently works for version documents simply because it assigns them to the `draft` property. This commit clarifies the situation by adding a dedicated `versions` property to the collator. In practice, Studio behaviour should be unchanged.
juice49
added a commit
that referenced
this pull request
Feb 27, 2025
This property was unused, and computed incorrectly, referring to `doc.id` instead of `doc._id`.
juice49
added a commit
that referenced
this pull request
Feb 27, 2025
juice49
force-pushed
the
fix/groq-2024-search-versions
branch
from
3be2dc4 to
21e7565
Compare
The document collator currently inadvertently works for version documents simply because it assigns them to the `draft` property. This commit clarifies the situation by adding a dedicated `versions` property to the collator. In practice, Studio behaviour should be unchanged.
This property was unused, and computed incorrectly, referring to `doc.id` instead of `doc._id`.
juice49
force-pushed
the
fix/groq-2024-search-versions
branch
from
21e7565 to
59a8a82
Compare
bjoerge
approved these changes
Mar 6, 2025
| @@ -20,15 +20,13 @@ export function getDocumentKey(value: DocumentListPaneItem, index: number): stri | |||
|
|
|||
| export function removePublishedWithDrafts(documents: SanityDocumentLike[]): DocumentListPaneItem[] { | |||
| return collate(documents).map((entry) => { | |||
| const doc = entry.draft || entry.published | |||
| const isVersion = doc?.id && isVersionId(doc._id) | |||
| const doc = entry.draft || entry.published || entry.versions[0] | |||
There was a problem hiding this comment.
we could perhaps consider adding a preference for what version to chose, but probably better to defer that to when we need it
There was a problem hiding this comment.
I think that could be a good idea. Settled for this now just to make things a bit clearer.
juice49
added a commit
that referenced
this pull request
Mar 7, 2025
The document collator currently inadvertently works for version documents simply because it assigns them to the `draft` property. This commit clarifies the situation by adding a dedicated `versions` property to the collator. In practice, Studio behaviour should be unchanged.
juice49
added a commit
that referenced
this pull request
Mar 7, 2025
This property was unused, and computed incorrectly, referring to `doc.id` instead of `doc._id`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
groq2024search strategy currently relies on Content Lake perspectives to collate documents. This means global search is unable to discover document versions outside of the selected perspective.This branch changes back to the
rawperspective and returns to client-side collation in order to make all document versions discoverable via global search, regardless of the selected perspective.What to review
Global search: discoverability of versions outside the selected perspective.
Document lists: should be unchanged.
Testing
Updated unit tests and tested manually.