test(e2e): set up display documents e2e #8828
Open
+668
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
No changes to documentation |
Coverage Report
File CoverageNo changed files found. |
|
Component Testing Report Updated Mar 11, 2025 7:44 AM (UTC) ❌ Failed Tests (3) -- expand for details
|
⚡️ Editor Performance ReportUpdated Tue, 11 Mar 2025 14:33:19 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
RitaDias
force-pushed
the
sapp-2388-e2e-tests
branch
from
e051582 to
d9b99cc
Compare
RitaDias
force-pushed
the
sapp-2388-e2e-tests
branch
from
d53da6f to
878729b
Compare
RitaDias
force-pushed
the
sapp-2388-e2e-tests
branch
from
095eb45 to
54d097f
Compare
RitaDias
force-pushed
the
sapp-2388-e2e-tests
branch
from
9156e36 to
b7a3fe0
Compare
RitaDias
force-pushed
the
sapp-2388-e2e-tests
branch
from
c19ad64 to
fde70ef
Compare
test(e2e): update e2e tests test(e2e): first stab at e2e new tests test(e2e): remove unneeded before each test(e2e): add more tests test(e2e): add more tests test(e2e): add more tests test(e2e): add more tests test(e2e): add more tests test(e2e): clean up test(e2e): clean up test(e2e): add more tests refactor(structure): updated condition based on suggestion e2e(structure): move e2e tests to the files e2e(structure): add test
RitaDias
force-pushed
the
sapp-2388-e2e-tests
branch
from
bd82255 to
1cf08af
Compare
bjoerge
reviewed
Mar 11, 2025
| test.afterAll(async ({sanityClient}) => { | ||
| const dataset = sanityClient.config().dataset | ||
|
|
||
| await archiveRelease({sanityClient, dataset, releaseId: asapReleaseId}) |
There was a problem hiding this comment.
wondering if it were better if these were grouped by releaseId instead of operation. Now, if e.g archiving asapReleaseId fails for some reason, we won't get to archiving the undecidedReleaseId
| test.afterAll(async ({sanityClient}) => { | ||
| const dataset = sanityClient.config().dataset | ||
|
|
||
| await sanityClient.delete(publishedDocument._id) |
There was a problem hiding this comment.
If this fails, we'll leave the release around forever. Might not be a big deal as we're probably deleting the dataset anwyay
There was a problem hiding this comment.
If I'm not mistaken the datasets are deleted per run (might be mistaken, is that not the case?) Or at least that was my assumption.
If it fails it does indeed stay forever, but I feel that this is for us to fix outside of the scope of the code, unless you feel there is something we can do to make it more certain that this succeeds?
RitaDias
force-pushed
the
sapp-2388-e2e-tests
branch
from
47401f2 to
d248c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added e2e tests to test document displayed from sapp-2388
What to review
Do the tests make sense?
Notes for release
N/A