Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes update the ext/xxHash to v0.8.0 and fix the build problems that this causes.
As documented in the commit, upstream xxHash has added a subtree containing C test files. The way Module::Build is implemented,
c_source
can only add a tree recursively, meaning that it will spot all these new files, and attempt to compile and link them all. This breaks.Having asked on #toolchain for advice, Leon Timmermans suggests that the easiest way to keep the current structure (the entirety of xxHash checked out) is to subclass Module::Build and special case
process_support_files
. So this is what I have done.Passes tests on 3 different Linux architectures, which roughly the limit of what I have direct access to.