Fix for failing tests due to IndexOutOfRangeException in DefaultMp4SampleList, Fix for FragmentedMp4Writer producing invalid MP4 file #466
+143
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimm98y
changed the title
…y, fixed missing namespace, fixed incorrect nal being passed to SequenceParameterSetRbsp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently many tests are failing because of an IndexOutOfRangeException in DefaultMp4SampleList on line 74. "entries" are empty because parseDetails has not been called to populate them.
Additionally, FragmentedMp4Writer was producing an invalid mp4 files with all samples in the "trun" box having zero size. This is also fixed and I've added a test for the FragmentedMp4Writer that now produces playable mp4 file.
Also fixes #334.
Finally, H265 muxing now produces a valid mp4 file that can be played in both Media player on Windows and VLC/ffmpeg.