Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watermark Script added #280

Closed
wants to merge 2 commits into from
Closed

Conversation

kuldip11
Copy link
Contributor

@kuldip11 kuldip11 commented Nov 6, 2020

Your checklist for this pull request

⚠️ Please review the guidelines for contributing to this repository.

Parent issue: #257

Type of change

Select all that applies:

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines(Clean Code) of this project.
  • I have performed a self-review of my own code.
  • I have used consistent code conventions and clear function/method/variable names.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have created a helpful and easy to understand README.md which contains description, requirements and use case.
  • I have added relevent screenshots/images if necessary in a seperate folder.
  • I have added my work in respective language folder.
  • My changes generate no new warnings.

❤️ Thank you!

@kuldip11
Copy link
Contributor Author

kuldip11 commented Nov 6, 2020

I got confused for removing the previous commits so i created a new PR @SANKET7738

@kuldip11 kuldip11 closed this Nov 6, 2020
@kuldip11 kuldip11 deleted the branch_ branch November 6, 2020 15:51
@kuldip11 kuldip11 restored the branch_ branch November 6, 2020 15:52
@kuldip11 kuldip11 reopened this Nov 6, 2020
@kuldip11
Copy link
Contributor Author

kuldip11 commented Nov 7, 2020

@tejan-singh please review this pull request

@tejan-singh
Copy link
Contributor

@kuldip11 when you work on the branch, please try to name that branch properly relevent to you work. It created confusion while we review your branch.

- The OpenCV and Numpy Libraries are used to built this scripts.
## Requirements
- install OpenCv (use command:- "pip install opencv-python" to install OpenCv through Command Prompt)
- install ffpyplayer (use command:- "pip install ffpyplayer" to install ffpyplayer through Command Prompt)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am getting error for ffpyplayer installation. Can you please specify the version of this module you used

@kuldip11 kuldip11 closed this Nov 7, 2020
@kuldip11 kuldip11 deleted the branch_ branch November 7, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants