Thin out dependencies some #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Pretty sure that this is a breaking API change, since someone with Given that, perhaps it's better to not have it be on by default. The only times I've ever wanted complex number SIMD were for FFTs or fractal rendering, neither of which seem that common to me. Your call though, obviously. |
thomcc
commented
Feb 2, 2025
| @@ -136,6 +136,7 @@ impl Default for Arch { | |||
| include!(concat!(env!("OUT_DIR"), "/x86_64_asm.rs")); | |||
|
|
|||
| #[cfg(test)] | |||
| #[cfg_attr(not(feature = "complex"), allow(unused_imports))] | |||
There was a problem hiding this comment.
I'm being somewhat lazy here but without the complex stuff there were a lot of imports that became unused (in this test module in particular).
|
is there a notable benefit to making complex support optional? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused dependencies and makes the
num-complexdependency optional (Hopefully I got everything).