martian: cancel request context on downstream disconnection #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves performance by limiting the number of backgroundRead goroutines to 1. The read access is controlled by a read semaphore.
Notice that it used to return neterr.Timeout error as closable. This was wrong as we want to retry on any timeout error. This is why handle loop checks for maxConsecutiveErrors.
|
The requirement of using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a background read mechanism for martian proxy conn. Background read affects simple roundTrip path. Once the request body is consumed in roundTrip, background read will begin, canceling conn context in an error occurs. This idea was inspired by http.Server.
This partially fixes #800. The other patch in progress.