martian: add graceful close timeout for bicopy #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notice that it used to return neterr.Timeout error as closable. This was wrong as we want to retry on any timeout error. This is why handle loop checks for maxConsecutiveErrors.
Choraden
force-pushed
the
hg/bicopy_imp_close
branch
from
b25604c to
5db1cb1
Compare
|
@budziam Changed the log level to info. |
budziam
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent the proxy from leaking connections with defective servers.
Given limited resources, this is the best we can do for #800 right now.
That fix cannot be tested due to #1013. Enable the test again once that is fixed.
For now I tested it manually.