Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

martian: enable gosec, errcheck and bodyclose linters #973

Merged
merged 18 commits into from
Dec 4, 2024
Merged

Conversation

mmatczuk
Copy link
Contributor

@mmatczuk mmatczuk commented Dec 3, 2024

Fixes #361
Fixes #363
Fixes #360

@mmatczuk mmatczuk requested a review from Choraden as a code owner December 3, 2024 16:39
@mmatczuk mmatczuk force-pushed the mmt/gosec branch 2 times, most recently from c8bc39b to b8db6e6 Compare December 4, 2024 10:19
.golangci.yml Show resolved Hide resolved
@mmatczuk mmatczuk changed the title martian: enable gosec martian: enable gosec, errcheck and bodyclose linters Dec 4, 2024
Comment on lines +163 to +165
defer func() {
p.traceWroteResponse(res, ferr)
}()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

Copy link
Contributor

@Choraden Choraden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mmatczuk mmatczuk merged commit a19445a into main Dec 4, 2024
6 checks passed
@mmatczuk mmatczuk deleted the mmt/gosec branch December 4, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

martian: enable errcheck linter martian: enable gosec linter golangci: review bodyclose linter
2 participants