martian/header: optimized ViaModifier implementation #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatczuk
force-pushed
the
mmt/has_loop2
branch
from
c2ef68e to
49c5498
Compare
Choraden
reviewed
Dec 4, 2024
| if v := req.Header.Get("Via"); v != "" { | ||
| if m.hasLoop(v) { | ||
| if via != "" { | ||
| if strings.Contains(via, m.requestedBy+"-"+m.boundary) { |
There was a problem hiding this comment.
How about precomputing m.requestedBy+"-"+m.boundary instead of concatenating on every modify?
|
LGTM. I feel that optimisations are correct, but it would be useful to have #676. |
- ViaModifier immutable - Remove regex - Remove splitting - Allocate single chunk of memory (strings.Builder) - Precompute tag - Precompute common http literals Fixes #924
mmatczuk
force-pushed
the
mmt/has_loop2
branch
from
49c5498 to
99c4d8e
Compare
|
@Choraden check the new implementation |
|
I'm on it we can wait and see |
|
Here we could have a microbenchmark |
That's true. |
|
benchstat old.txt new.txt
goos: darwin
goarch: arm64
pkg: github.com/saucelabs/forwarder/internal/martian/header
cpu: Apple M1 Pro
│ old.txt │ new.txt │
│ sec/op │ sec/op vs base │
ViaModifier 2299.0n ± 3% 154.3n ± 2% -93.29% (p=0.000 n=10)
│ old.txt │ new.txt │
│ B/op │ B/op vs base │
ViaModifier 1440.0 ± 0% 160.0 ± 0% -88.89% (p=0.000 n=10)
│ old.txt │ new.txt │
│ allocs/op │ allocs/op vs base │
ViaModifier 31.000 ± 0% 4.000 ± 0% -87.10% (p=0.000 n=10)
|
It was indeed slow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.