middleware(prometheus): use summaries instead of histograms #975
Conversation
It is much more efficient to use summaries than histograms. This would give information on p50, p90 and p99. Fixes #925
mmatczuk
force-pushed
the
mmt/histograms
branch
from
386b16c to
33cdac3
Compare
|
Can you provide information on how much time |
|
Once we deploy we can do some new benchmarking, to compare apples to apples. |
| # TYPE test_http_request_size_bytes summary | ||
| test_http_request_size_bytes{code="200",method="GET",quantile="0.5"} 5171 | ||
| test_http_request_size_bytes{code="200",method="GET",quantile="0.9"} 102451 | ||
| test_http_request_size_bytes{code="200",method="GET",quantile="0.99"} 102451 |
There was a problem hiding this comment.
Request size does not look useful in a summary like this.
There was a problem hiding this comment.
It's not about summary, but rather request size itself.
While duration may outline some slower requests, size does not matter that much.
There was a problem hiding this comment.
You suggest we remove it altogether?
There was a problem hiding this comment.
Counting the sizes requires some technical prep work (wrapping) we could get rid of.
There was a problem hiding this comment.
I'm hesitating, but it looks like we could get rid of it.
mmatczuk
force-pushed
the
mmt/histograms
branch
from
73b686e to
2af155e
Compare
mmatczuk
force-pushed
the
mmt/histograms
branch
from
2af155e to
0702551
Compare
|
@Choraden PTAL |
It is much more efficient to use summaries than histograms. This would give information on p50, p90 and p99.
Fixes #925