Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF-2310] Add auth parameter to jobReport endpoint #21

Merged
merged 3 commits into from
Jul 27, 2020

Conversation

maciejurbanskisaucelabs

We need to make sure video is visible to users without being logged to sauce app in the browser.

@farhan-sauce
Copy link

farhan-sauce commented May 27, 2020

It's fine for now, but adding new method getJobUrl either in JenkinsJobInformation or in JobInformation could be a neat solution.

@maciejurbanskisaucelabs maciejurbanskisaucelabs changed the title [WIP] [PERF-2310] Add auth parameter to jobReport endpoint [PERF-2310] Add auth parameter to jobReport endpoint May 27, 2020
@maciejurbanskisaucelabs
Copy link
Author

JenkinsJobInformation

@maciejurbanskisaucelabs
Copy link
Author

It's fine for now, but adding new method getJobUrl either in JenkinsJobInformation or in JobInformation could be a neat solution.

There is e method adding auth parameter to the url.

    public String getLogUrl() {
        try {
            URIBuilder uriBuilder = new URIBuilder(super.getLogUrl());
            uriBuilder.addParameter("auth", this.getHmac());
            return uriBuilder.toString();
        } catch (URISyntaxException e) {
            e.printStackTrace();
        }
        return super.getLogUrl();

I need to understand what it uses as base url.

@maciejurbanskisaucelabs maciejurbanskisaucelabs force-pushed the feat/PERF-2310/pass_auth branch 8 times, most recently from 09316fb to 21f2cc0 Compare May 28, 2020 21:24
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4b7985c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #21   +/-   ##
=========================================
  Coverage          ?   39.76%           
  Complexity        ?      170           
=========================================
  Files             ?       29           
  Lines             ?     1808           
  Branches          ?      263           
=========================================
  Hits              ?      719           
  Misses            ?      999           
  Partials          ?       90           

@maciejurbanskisaucelabs maciejurbanskisaucelabs force-pushed the feat/PERF-2310/pass_auth branch 4 times, most recently from a9bb42a to b14b7fb Compare May 29, 2020 07:45
In building test clean plugin was being fetched from http. Since begining of the year maven repos support https only.
This change fixes The forked VM terminated without saying properly goodbye. VM crash or System.exit called
This solves usage of mysterious findbug 3.0.3 version which throws errors when used with maven 3.6.x
@maciejurbanskisaucelabs maciejurbanskisaucelabs merged commit a921563 into master Jul 27, 2020
@diemol diemol deleted the feat/PERF-2310/pass_auth branch October 25, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants