Fix nullpointer #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return the {@link SauceOnDemandBuildAction} instance which has been registered with the build | ||
| * Can be null | ||
| */ | ||
| private static SauceOnDemandBuildAction getBuildAction(Run build) { |
There was a problem hiding this comment.
This code is repeated and copied from SauceOnDemandReportPublisher.java, @halkeye is it a good idea to move it into some utility file, to be reused?
|
👍 i like it |
Current coverage is 36.00%@@ master #6 diff @@
==========================================
Files 28 28
Lines 1311 1311
Methods 0 0
Messages 0 0
Branches 220 220
==========================================
- Hits 656 472 -184
- Misses 654 777 +123
- Partials 1 62 +61
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@halkeye Reopening PR here, earlier had it in upstream.