Stop sauce before timeout #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yfangsl
commented
Sep 22, 2017
yfangsl
commented
- Added a checkbox to force job/tunnel cleanup in the build configuration page
- It will look for tunnels with the associated tunnel_id and stop them.
- It will stop jobs, then wait up to 5 seconds for additional jobs that might get added and stop those too. If it finds new jobs, the timer is reset.
- Sanitized build names in a way that matches what the API calls were returning so jobs could be matched
- The job id list was missing an item in the loop, which was preventing proper cleanup
…ing an item, add checkbox to force build cleanups to handle build aborts leaving sauce jobs/tunnels in a 90s timeout
…addition to tunnel ids
…ntly delays tests
christian-bromann
approved these changes
Sep 25, 2017
There was a problem hiding this comment.
Code changes look good to me but @halkeye might have a better opinion on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.