Use latest sauce connect 5 version by default #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choraden
reviewed
Jan 31, 2025
| @@ -3,9 +3,9 @@ import os from 'os'; | |||
|
|
|||
| import {version} from '../package.json'; | |||
|
|
|||
| export const DEFAULT_SAUCE_CONNECT_VERSION = '5.2.2'; | |||
| export const DEFAULT_SAUCE_CONNECT_VERSION = '5'; | |||
There was a problem hiding this comment.
Does it run a container or how will it know latest version?
There was a problem hiding this comment.
It makes requests to saucelabs api using this parameter: https://api.us-west-1.saucelabs.com/rest/v1/public/tunnels/sauce-connect/download?arch=arm64&os=macos&version=5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Description
Use the latest SC v5 by default
Types of Changes
What types of changes does your code introduce? Keep the ones that apply: