feat: add livelogs support #869
Merged
+491
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
alexplischke
previously approved these changes
Jan 8, 2024
alexplischke
reviewed
Jan 8, 2024
alexplischke
reviewed
Jan 9, 2024
sebv
force-pushed
the
livelogs
branch
3 times, most recently
from
3fcb25b to
91bee05
Compare
Comment on lines
+218
to
+229
| func ignoreError(err error) bool { | ||
| if err == nil { | ||
| return true | ||
| } | ||
| if !errors.Is(err, context.Canceled) { | ||
| return true | ||
| } | ||
| if strings.Contains(err.Error(), "websocket: close") { | ||
| return true | ||
| } | ||
| return false | ||
| } |
There was a problem hiding this comment.
Considering that this is a function to be used somewhere and is defined at the package level, it kinda lacks context as to when it should be used (i.e. its name is too generic, suggesting that it could be used for any error check in this package). Has no docs either. If
saucectl/internal/saucecloud/imagerunner.go
Line 309 in e166ab0
alexplischke
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds livelogs support
Types of changes