Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tag aware sharding for cucumber-playwright #933

Merged
merged 20 commits into from
Aug 9, 2024
Merged

feat: Tag aware sharding for cucumber-playwright #933

merged 20 commits into from
Aug 9, 2024

Conversation

mhan83
Copy link
Contributor

@mhan83 mhan83 commented Aug 8, 2024

Description

When using tags as part of a suite configured to shard, it's possible for saucectl to launch jobs with no tests to run. e.g. if the feature file contains no scenarios matching the given tag expression.

Instead, we can have saucectl parse the feature files and exclude any files that do not match the given tag expression.

Comments

The equivalent behaviour for a cypress suite is enabled with the shardGrepEnabled configuration. Using the same name here could be confusing since "grep" doesn't really map to what's happening. Went with shardTagEnabled which is sort of meh.

The other option is to just enable the behaviour if the user has any tags specified in the suite. Since we're using the official gherkin parser there should be more confidence that the filtering works as expected.

DEVX-2794

@mhan83 mhan83 added enhancement New feature or request playwright Pull requests that affect playwright integration labels Aug 8, 2024
@mhan83 mhan83 requested a review from a team as a code owner August 8, 2024 16:51
@mhan83 mhan83 changed the title feat: Add option to filter cucumber feature files by tag expression feat: Tag aware sharding for playwright-cucumber Aug 8, 2024
@mhan83 mhan83 changed the title feat: Tag aware sharding for playwright-cucumber feat: Tag aware sharding for cucumber-playwright Aug 8, 2024
@mhan83 mhan83 merged commit 6a1d389 into main Aug 9, 2024
16 checks passed
@mhan83 mhan83 deleted the devx-2794 branch August 9, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request playwright Pull requests that affect playwright integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants