feat: Tag aware sharding for cucumber-playwright #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhan83
added
enhancement
mhan83
changed the title
mhan83
changed the title
alexplischke
reviewed
Aug 8, 2024
alexplischke
reviewed
Aug 8, 2024
alexplischke
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using tags as part of a suite configured to shard, it's possible for saucectl to launch jobs with no tests to run. e.g. if the feature file contains no scenarios matching the given tag expression.
Instead, we can have saucectl parse the feature files and exclude any files that do not match the given tag expression.
Comments
The equivalent behaviour for a cypress suite is enabled with the
shardGrepEnabledconfiguration. Using the same name here could be confusing since "grep" doesn't really map to what's happening. Went withshardTagEnabledwhich is sort of meh.The other option is to just enable the behaviour if the user has any tags specified in the suite. Since we're using the official gherkin parser there should be more confidence that the filtering works as expected.
DEVX-2794