Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence error in GraphSheet sidebar #2633

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Conversation

midichef
Copy link
Contributor

@midichef midichef commented Dec 9, 2024

Closes #2601 and #2629.

The error in #2601 comes because a sheet needs to have either default_sidebar or guide. Most sheets have at least a default empty guide because they inherit one from TableSheet. But there are three other subclasses of BaseSheet that are separate from TableSheet: Plotter, TextCanvas, and FormCanvas.

GraphSheet comes from Plotter: Plotter -> Canvas -> InvertedCanvas -> GraphSheet. So I fixed the problem by adding an empty guide to Canvas, to head off the same issue in the several sheet types that are subclasses of Canvas, like GeoJSONMap.

@anjakefala anjakefala merged commit 59721d0 into saulpw:develop Jan 4, 2025
14 checks passed
@midichef midichef deleted the canvas_guide branch January 4, 2025 07:04
@midichef midichef mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphSheet needs a default help_sidebars.
3 participants