refactor to use the Responses helper to mock faraday responses

savonrb · Jan 9, 2024 · c5d8720 · c5d8720
1 parent 4cebdf8
commit c5d8720
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/lib/savon/mock/expectation.rb b/lib/savon/mock/expectation.rb
@@ -41,7 +41,7 @@ def response!
       unless @response
         raise ExpectationError, "This expectation was not set up with a response."
       end
-      env = Faraday::Env.new(status: @response[:code], response_headers: @response[:headers], response_body: @response[:body])
+      env = Faraday::Env.from(status: @response[:code], response_headers: @response[:headers], response_body: @response[:body])
       Faraday::Response.new(env)
     end
 

diff --git a/spec/savon/http_error_spec.rb b/spec/savon/http_error_spec.rb
@@ -51,8 +51,7 @@ def new_response(options = {})
     defaults = { :code => 200, :headers => {}, :body => Fixture.response(:authentication) }
     response = defaults.merge options
 
-    env = Faraday::Env.new(status: response[:code], response_headers: response[:headers], response_body: response[:body])
-    Faraday::Response.new(env)
+    Responses.mock_faraday(response[:code], response[:headers], response[:body])
   end
 
 end
diff --git a/spec/savon/response_spec.rb b/spec/savon/response_spec.rb
@@ -252,9 +252,7 @@
   def soap_response(options = {})
     defaults = { :code => 200, :headers => {}, :body => Fixture.response(:authentication) }
     response = defaults.merge options
-    env = Faraday::Env.new(status: response[:code], response_headers: response[:headers], response_body: response[:body])
-    http_response = Faraday::Response.new(env)
-
+    http_response = Responses.mock_faraday(response[:code], response[:headers], response[:body])
     Savon::Response.new(http_response, globals, locals)
   end
 
@@ -269,8 +267,7 @@ def http_error_response
   def invalid_soap_response(options = {})
     defaults = { :code => 200, :headers => {}, :body => "I'm not SOAP" }
     response = defaults.merge options
-    env = Faraday::Env.new(status: response[:code], response_headers: response[:headers], response_body: response[:body])
-    http_response = Faraday::Response.new(env)
+    http_response = Responses.mock_faraday(response[:code], response[:headers], response[:body])
 
     Savon::Response.new(http_response, globals, locals)
   end