Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide lean context config #3233

Merged
merged 17 commits into from
Nov 28, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons commented Nov 22, 2024

Preflight Checklist

Issue

This PR Closes #3010

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

See Review Guidelines for more information what is checked during review process.

Changes

Changes in this pull request:

  • the isLean function has been added: it checks if the document tag has the sbb-lean class;
  • a new lean example page has been created under the page folder;
  • the sbb-table in lean mode automatically takes the CSS rules of the sbb-table-s class;
  • the following components has been modified in order to have the smallest size in lean mode:
    • sbb-accordion
    • sbb-action-group
    • sbb-alert
    • sbb-button
    • sbb-button-link
    • sbb-button-static
    • sbb-secondary-button
    • sbb-secondary-button-link
    • sbb-secondary-button-static
    • sbb-tertiary-button
    • sbb-tertiary-button-link
    • sbb-tertiary-button-static
    • sbb-transparent-button
    • sbb-transparent-button-link
    • sbb-transparent-button-static
    • sbb-mini-button
    • sbb-mini-button-group
    • sbb-card
    • sbb-checkbox
    • sbb-checkbox-group
    • sbb-checkbox-panel
    • sbb-dialog-actions
    • sbb-file-selector
    • sbb-file-selector-dropzone
    • sbb-form-field
    • sbb-header
    • sbb-journey header
    • sbb-link list
    • sbb-link list-anchor
    • sbb-block-link
    • sbb-block-link-button
    • sbb-block-link-static
    • sbb-link
    • sbb-link-button
    • sbb-link-static
    • sbb-navigation-button
    • sbb-navigation-link
    • sbb-navigation-list
    • sbb-navigation marker
    • sbb-notification
    • sbb-paginator
    • sbb-paginator-compact
    • sbb-radio-button
    • sbb-radio-button-group
    • sbb-radio-button-panel
    • sbb-skiplink-list
    • sbb-stepper
    • sbb-tab-group
    • sbb-tag
    • sbb-tag-group
    • sbb-toast
    • sbb-toggle
    • sbb-toggle-check
    • sbb-visual checkbox

Browsers

I tested the build on the following browsers:

  • Firefox Desktop
  • Chrome Desktop
  • Edge Desktop
  • Safari Desktop
  • Chrome Mobile
  • Safari Mobile

Screen readers

I tested the build on the following browsers:

  • JAWS Firefox Desktop
  • JAWS Chrome Desktop
  • NVDA Firefox Desktop
  • NVDA Chrome Desktop
  • VoiceOver Safari Desktop
  • VoiceOver Chrome Desktop
  • VoiceOver Safari Mobile
  • Android Accessibility Suite Chrome Mobile

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

@DavideMininni-Fincons DavideMininni-Fincons linked an issue Nov 22, 2024 that may be closed by this pull request
…text-config

# Conflicts:
#	src/elements/alert/alert/alert.ts
#	src/elements/file-selector/file-selector.ts
#	src/elements/file-selector/file-selector/readme.md
#	src/elements/paginator/paginator/readme.md
@DavideMininni-Fincons DavideMininni-Fincons marked this pull request as ready for review November 22, 2024 17:06
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Nov 22, 2024
@github-actions github-actions bot temporarily deployed to pr3233 November 22, 2024 17:29 Inactive
@github-actions github-actions bot temporarily deployed to pr3233-diff November 22, 2024 17:30 Inactive
docs/GETTING_STARTED.md Outdated Show resolved Hide resolved
docs/GETTING_STARTED.md Outdated Show resolved Hide resolved
src/elements/accordion/readme.md Outdated Show resolved Hide resolved
src/storybook/pages/home/home-lean-logged-in.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done! :) Found some cases

src/elements/action-group/action-group.ts Outdated Show resolved Hide resolved
src/elements/alert/alert/alert.ts Outdated Show resolved Hide resolved
src/storybook/pages/lean/lean.scss Outdated Show resolved Hide resolved
src/storybook/pages/lean/lean.scss Outdated Show resolved Hide resolved
src/storybook/pages/lean/lean.stories.ts Outdated Show resolved Hide resolved
src/storybook/pages/lean/lean.stories.ts Outdated Show resolved Hide resolved
@jeripeierSBB jeripeierSBB added the pr: ux review required A ux review is required for this pull request label Nov 27, 2024
# Conflicts:
#	src/elements/checkbox/checkbox/checkbox.ts
#	src/elements/header/header/readme.md
#	src/storybook/pages/home/home.stories.ts
Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Nov 28, 2024
@DavideMininni-Fincons DavideMininni-Fincons merged commit 0e2a847 into main Nov 28, 2024
31 of 32 checks passed
@DavideMininni-Fincons DavideMininni-Fincons deleted the feat/provide-lean-context-config branch November 28, 2024 13:33
@github-actions github-actions bot removed the pr: peer review required A peer review is required for this pull request label Nov 28, 2024
@github-actions github-actions bot mentioned this pull request Nov 28, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: ux review required A ux review is required for this pull request pr: visual review required preview-available target: 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

story: provide lean context config
2 participants