fix: add class generic type param in manifest #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideMininni-Fincons
requested review from
kyubisation and
jeripeierSBB
as code owners
DavideMininni-Fincons
requested review from
TomMenga,
MarioCastigliano and
dauriamarco
github-actions
bot
added
the
pr: peer review required
github-actions
bot
added
preview-available
pr: visual review required
diff-available
labels
github-actions
bot
added
the
pr: lead review approved
github-actions
bot
removed
the
pr: peer review required
sbb-design-systems-bot bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
The datepicker and the calendar components use generic type parameter to
allow custom implementation of Date, eg.
```
export class SbbDatepickerElement<T = Date> {
private _min?: T | null;
// and so on
}
```
This needs to be taken in account in Angular classes generation, so a
new param has been added to the manifest during its generation, eg.
```
{
"kind": "javascript-module",
"path": "datepicker/datepicker.js",
"declarations": [
{
"kind": "class",
"description": "Combined with a native input, it displays the input's value as a formatted date.",
"name": "SbbDatepickerElement",
"members": [],
"events": [],
"attributes": [],
"superclass": {},
"classGenerics": "T = Date", <--------------------------------- new property
"tagName": "sbb-datepicker",
"customElement": true
}
],
exports: []
```
github-actions
bot
added
the
pr: peer review required
jeripeierSBB
changed the title
jeripeierSBB
pushed a commit
that referenced
this pull request
Dec 12, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.1](v2.0.0...v2.0.1) (2024-12-12) ### Features * add class generic type param in manifest ([#3292](#3292)) ([3d872c1](3d872c1)) ### Bug Fixes * **sbb-message:** support the use of `figure` as image ([#3294](#3294)) ([1d64853](1d64853)) * **sbb-radio-button-panel:** remove extension clause in mixin which cause incorrect manifest generation ([#3288](#3288)) ([b5457a7](b5457a7)) * **sbb-teaser:** fix image related issues ([#3293](#3293)) ([e6f517b](e6f517b)) ### Miscellaneous Chores * release 2.0.1 ([2a43d06](2a43d06)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: add class generic type param in manifest (#3292)
END_COMMIT_OVERRIDE
The datepicker and the calendar components use generic type parameter to allow custom implementation of Date, eg.
This needs to be taken in account in Angular classes generation, so a new param has been added to the manifest during its generation, eg.