Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: prepare standalone usage of buttons #3326

Merged
merged 5 commits into from
Jan 28, 2025
Merged

refactor: prepare standalone usage of buttons #3326

merged 5 commits into from
Jan 28, 2025

Conversation

jeripeierSBB
Copy link
Contributor

@jeripeierSBB jeripeierSBB commented Dec 23, 2024 •
edited
Loading

We want to provide mixins (classes?) for the sbb-button to allow place it on a native <button> element. To achieve this goal, this PR refactors the styles of the button, which is a prerequisite for #3075

Open topics:

  • forced Colors negative has glitch:
    image
  • testing on small resolutions screens
  • Do we accept slightly less smooth border radius?

@github-actions github-actions bot temporarily deployed to pr3326 December 23, 2024 14:35 Inactive
@github-actions github-actions bot temporarily deployed to pr3326-diff December 23, 2024 14:35 Inactive
@github-actions github-actions bot temporarily deployed to pr3326 December 23, 2024 18:52 Inactive
@github-actions github-actions bot temporarily deployed to pr3326-diff December 23, 2024 18:53 Inactive
@github-actions github-actions bot temporarily deployed to pr3326 December 24, 2024 09:16 Inactive
@github-actions github-actions bot temporarily deployed to pr3326-diff December 24, 2024 09:17 Inactive
@github-actions github-actions bot temporarily deployed to pr3326 December 24, 2024 10:45 Inactive
@github-actions github-actions bot temporarily deployed to pr3326-diff December 24, 2024 10:46 Inactive
@jeripeierSBB jeripeierSBB marked this pull request as ready for review December 24, 2024 13:51
@jeripeierSBB jeripeierSBB added the pr: ux review required A ux review is required for this pull request label Dec 24, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Dec 24, 2024
@mcilurzo mcilurzo added ux approved Issue is approved by UX and removed pr: ux review required A ux review is required for this pull request labels Jan 22, 2025
@mcilurzo
Copy link
Contributor

LGTM!

@jeripeierSBB jeripeierSBB added pr: ux review approved Pull request has been approved by a ux review and removed ux approved Issue is approved by UX labels Jan 22, 2025
@jeripeierSBB
Merge branch 'main' into button-refactoring-6
8d20033 
# Conflicts:
#	src/elements/core/a11y/focus.ts
@jeripeierSBB
fix: review
1a2a35f
kyubisation
kyubisation approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Jan 28, 2025
@jeripeierSBB jeripeierSBB merged commit b8fdd9d into main Jan 28, 2025
19 of 20 checks passed
@jeripeierSBB jeripeierSBB deleted the button-refactoring-6 branch January 28, 2025 11:13
@github-actions github-actions bot added pr: peer review required A peer review is required for this pull request and removed pr: peer review required A peer review is required for this pull request labels Jan 28, 2025
sbb-design-systems-bot bot pushed a commit that referenced this pull request Jan 28, 2025
@jeripeierSBB
refactor: prepare standalone usage of buttons (#3326)
154370b 
We want to provide mixins for the sbb-button to allow place
it on a native `<button>` element. To achieve this goal, this PR
refactors the styles of the button, which is a prerequisite for #3075
@github-actions github-actions bot mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyubisation kyubisation kyubisation approved these changes

@mcilurzo mcilurzo Awaiting requested review from mcilurzo

Assignees
No one assigned
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review required A peer review is required for this pull request pr: ux review approved Pull request has been approved by a ux review pr: visual review required preview-available target: 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeripeierSBB @mcilurzo @kyubisation