Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(journey-maps): new POIs category p2p_car_sharing #2108

Merged

Conversation

PLC-SBB
Copy link
Contributor

@PLC-SBB PLC-SBB commented Dec 11, 2023

Refs: ROKAS-1672

@@ -300,6 +300,7 @@ export type SbbPointsOfInterestCategoryType =
| 'on_demand'
| 'optician'
| 'outdoor'
| 'p2p_car_sharing'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hier ist es natürlich korrekt so (alphabetisch sortiert).

Copy link
Contributor

@swiss-chris swiss-chris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested a deployment to preview-pr2108 December 11, 2023 16:42 In progress
Copy link
Contributor

@mstankala mstankala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kyubisation kyubisation merged commit fb8ec8d into main Dec 14, 2023
16 checks passed
@kyubisation kyubisation deleted the feature/ple/ROKAS-1672-new-poi-subcat-p2p-car-sharing branch December 14, 2023 12:58
sbb-design-systems-bot bot pushed a commit that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants