Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(journey-maps): new input field for journey-routes data #2346

Merged
merged 18 commits into from
Oct 17, 2024

Conversation

swiss-chris
Copy link
Contributor

Refs: ROKAS-2171

.husky/commit-msg Outdated Show resolved Hide resolved
@swiss-chris swiss-chris marked this pull request as draft September 16, 2024 12:06
Refs: ROKAS-2225
If needed, the old default style (v2) can be configured with the styleOptions input parameter.
SbbStyleOptions = {
  aerialId: 'aerial_sbb_ki_v2',
  brightId: 'base_bright_v2_ki_v2',
  darkId: 'base_dark_v2_ki_v2',
}
Copy link
Contributor

@mstankala mstankala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add examples files for routes.

src/journey-maps/angular/journey-maps.interfaces.ts Outdated Show resolved Hide resolved
src/journey-maps/angular/util/input-validation.ts Outdated Show resolved Hide resolved
@andrinsibold andrinsibold marked this pull request as ready for review October 11, 2024 08:10
Copy link
Contributor

@mstankala mstankala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thx Andrin

@mhaertwig mhaertwig merged commit 544ec19 into main Oct 17, 2024
18 checks passed
@mhaertwig mhaertwig deleted the feature/cdi/ROKAS-2171-support-journey-routes branch October 17, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants