fix(angular/menu): remove dependency on animations module #2472
+270
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks and reduce the bundle size.
mhaertwig
force-pushed
the
feature/menu
branch
from
3444617 to
a710ab0
Compare
mhaertwig
commented
Jan 13, 2025
| } | ||
| to { | ||
| width: 288px; | ||
| max-height: 100%; |
There was a problem hiding this comment.
Using max-height to animate the user menu's height creates a less fluid animation compared to directly animating its actual height.
In Angular animations, we achieved this smoothly by using height: '*', where the wildcard dynamically applies the element's height before the animation starts.
@jeripeierSBB, do you have any suggestions for improving the CSS transition?
There was a problem hiding this comment.
I got this working by using grid-template-rows for the height animation and by adding a <div class="sbb-menu-panel-content" /> wrapper element around the menu content.
kyubisation
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow us to avoid some of the pitfalls of the animations module like occasional memory leaks and reduce the bundle size.