Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(installer): rare case where sql_version is not defined (#965) #966

Open
wants to merge 1 commit into
base: php81
Choose a base branch
from

Conversation

Rushaway
Copy link
Contributor

@Rushaway Rushaway commented Jun 3, 2024

Description

Ensure $sql_version is defined, if not give it a default value of 0.0.0 to let the rest of code run and throw error to user.

Motivation and Context

#965

How Has This Been Tested?

Tested with the guys who have an issue on sbpp discord, and it's now sovled.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Rushaway
Copy link
Contributor Author

Rushaway commented Jun 3, 2024

instead of 0.0.0 maybe we can throw a message ? cc @Hackmastr

@Hackmastr
Copy link
Contributor

Hackmastr commented Jun 8, 2024

Hello,

Ideally, we should offer users the option to provide a version.
Thanks.

@Rushaway
Copy link
Contributor Author

Not sure, this not the normal behaviour to can not retrieve the version info. At this place something is already wrong. Allowing the user to provde a version does not mean the connection to the database was succesfull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants