Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(object-storage): clarification int-fix-object-storage #4508

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ahamez
Copy link
Member

@ahamez ahamez commented Feb 27, 2025

Your checklist for this pull request

Description

  • Make clear that a value is a default value
  • Remove external link that adds no value

The concept has been explained before. Furthermore, it leads to a
Wikipedia page which, in this case, doesn't bring any valuable
information (`syntax` or `version` are not mentioned in this page).

**Required**
: Yes

**Type**
: const

**Value**
**Default Value**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the "Default" here, this is a required value, but it does not default to this if empty or unrecognized

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, in this case, I proposed a new change:

Possible Value
: "2023-04-17" or "2012-10-17" (deprecated)


**Required**
: Yes

**Type**
: const

**Value**
**Default Value**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Default Value**
**Value**

@SamyOubouaziz SamyOubouaziz added the do not merge PR that shouldn't be merged before a specific date (eg release) label Feb 27, 2025

**Required**
: Yes

**Type**
: const

**Value**
: "2023-04-17"
**Possible Value**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Possible Value**
**Value**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge PR that shouldn't be merged before a specific date (eg release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants