-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Text): remove default color neutral #2990
Conversation
🦋 Changeset detectedLatest commit: 4667610 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
=======================================
Coverage 93.50% 93.50%
=======================================
Files 156 156
Lines 3293 3294 +1
Branches 424 426 +2
=======================================
+ Hits 3079 3080 +1
Misses 144 144
Partials 70 70
Continue to review full report in Codecov by Sentry.
|
Summary
Type
Summarise concisely:
What is expected?
Text is setting a neutral color by default if no sentiments is provided. Instead we should not do that so the text can inherit it's parent color if needed.