Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Text): white space #4572

Merged
merged 3 commits into from
Jan 2, 2025
Merged

feat(Text): white space #4572

merged 3 commits into from
Jan 2, 2025

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Feature

Summarise concisely:

What is expected?

<Text />: new prop whiteSpace

The following changes were made:

  1. Added a new prop

  2. Used the new prop in various Ultraviolet components (Snippet, Navigation...)

@lisalupi lisalupi self-assigned this Dec 11, 2024
@lisalupi lisalupi requested a review from matthprost as a code owner December 11, 2024 14:44
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 74657d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.44%. Comparing base (2205ef6) to head (74657d4).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4572   +/-   ##
=======================================
  Coverage   87.43%   87.44%           
=======================================
  Files         335      335           
  Lines       12722    12726    +4     
  Branches     3471     3521   +50     
=======================================
+ Hits        11124    11128    +4     
  Misses       1598     1598           
Files with missing lines Coverage Δ
packages/ui/src/components/Badge/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/Snippet/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Stepper/Step.tsx 97.53% <ø> (ø)
...es/ui/src/components/Text/__tests__/index.test.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Text/index.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40bd38...74657d4. Read the comment docs.

@lisalupi lisalupi force-pushed the feat/text-white-space branch from e84be8f to 74657d4 Compare January 2, 2025 16:29
@lisalupi lisalupi merged commit d8c3416 into main Jan 2, 2025
11 checks passed
@lisalupi lisalupi deleted the feat/text-white-space branch January 2, 2025 16:41
@scaleway-bot scaleway-bot mentioned this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants