Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(MenuV2): default portal to be document body #4585

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

matthprost
Copy link
Collaborator

@matthprost matthprost commented Dec 13, 2024

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Make portal of the menu attached to document body by default. This will allow using the MenuV2 into a list without triggering the scroll.

@matthprost matthprost added the refactor Refactor without breaking changes label Dec 13, 2024
@matthprost matthprost requested a review from a team December 13, 2024 10:55
@matthprost matthprost self-assigned this Dec 13, 2024
@matthprost matthprost requested review from alexandre-combemorel and JulienSaguez and removed request for a team December 13, 2024 10:55
@matthprost matthprost requested a review from lisalupi as a code owner December 13, 2024 10:55
Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: e23b736

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthprost matthprost merged commit 2f660df into main Dec 13, 2024
22 of 23 checks passed
@matthprost matthprost deleted the fix/menu-portal-attachement branch December 13, 2024 11:00
@scaleway-bot scaleway-bot mentioned this pull request Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (de622a2) to head (e23b736).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4585   +/-   ##
=======================================
  Coverage   87.58%   87.59%           
=======================================
  Files         335      335           
  Lines       12804    12805    +1     
  Branches     3485     3487    +2     
=======================================
+ Hits        11215    11216    +1     
  Misses       1589     1589           
Files with missing lines Coverage Δ
packages/ui/src/components/MenuV2/index.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f783531...e23b736. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants