Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(List): disabld state not properly working #4615

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Disabled state doesn't work on a row of a list.

Relevant logs and/or screenshots

Page Before After
url Screenshot 2024-12-20 at 15 50 36 Screenshot 2024-12-20 at 15 50 42

@matthprost matthprost added the bug Something isn't working label Dec 20, 2024
@matthprost matthprost requested a review from a team December 20, 2024 14:55
@matthprost matthprost self-assigned this Dec 20, 2024
@matthprost matthprost requested a review from lisalupi as a code owner December 20, 2024 14:55
@matthprost matthprost requested review from vincentaudebert and fabienhebert and removed request for a team December 20, 2024 14:55
Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 64eba27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (8bc5a6e) to head (64eba27).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4615   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         335      335           
  Lines       12812    12812           
  Branches     3534     3534           
=======================================
  Hits        11205    11205           
  Misses       1607     1607           
Files with missing lines Coverage Δ
packages/ui/src/components/List/Row.tsx 92.85% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef99be...64eba27. Read the comment docs.

@philibea philibea merged commit 39e17a6 into main Dec 24, 2024
12 of 13 checks passed
@philibea philibea deleted the fix/list-disabled-state branch December 24, 2024 09:23
@scaleway-bot scaleway-bot mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants