Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox-list): shift event checkbox was broken #4619

Merged
merged 5 commits into from
Dec 29, 2024
Merged

Conversation

philibea
Copy link
Collaborator

@philibea philibea commented Dec 24, 2024

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

Add the possibility to test with playwright

Show that the checkbox event is broken on the list
Close #4618

@philibea philibea requested review from a team, matthprost and lisalupi as code owners December 24, 2024 11:28
Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: 2dc6f69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 96.12403% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.43%. Comparing base (8bc5a6e) to head (ce0f4cc).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/List/ListContext.tsx 94.66% 4 Missing ⚠️
packages/ui/src/components/List/Row.tsx 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4619      +/-   ##
==========================================
- Coverage   87.45%   87.43%   -0.02%     
==========================================
  Files         335      335              
  Lines       12812    12720      -92     
  Branches     3534     3518      -16     
==========================================
- Hits        11205    11122      -83     
+ Misses       1607     1598       -9     
Files with missing lines Coverage Δ
...i/src/components/Checkbox/__tests__/index.test.tsx 72.97% <100.00%> (+4.31%) ⬆️
packages/ui/src/components/Checkbox/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/List/Cell.tsx 84.61% <100.00%> (ø)
packages/ui/src/components/List/HeaderRow.tsx 92.85% <100.00%> (-0.48%) ⬇️
...es/ui/src/components/List/__tests__/index.test.tsx 94.21% <ø> (ø)
packages/ui/src/components/List/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Radio/index.tsx 98.00% <100.00%> (ø)
packages/ui/src/components/SearchInput/index.tsx 94.59% <100.00%> (ø)
packages/ui/src/components/SwitchButton/index.tsx 90.47% <100.00%> (ø)
packages/ui/src/components/Table/HeaderRow.tsx 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e17a6...ce0f4cc. Read the comment docs.

@vincentaudebert
Copy link
Contributor

vincentaudebert commented Dec 26, 2024

IMHO on shift + click

Should mass check if one of the boxes is unchecked
Should mass uncheck if all the boxes are checked.

@philibea philibea merged commit 79a5b3a into main Dec 29, 2024
13 checks passed
@philibea philibea deleted the add-playwright branch December 29, 2024 18:35
@scaleway-bot scaleway-bot mentioned this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: List checkbox doesn't update state each click
4 participants