Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: timeInputV2 #4635

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: timeInputV2 #4635

wants to merge 2 commits into from

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Jan 2, 2025

Summary

Type

  • Feature

Summarise concisely:

What is expected?

New component <TimeInputV2 />

@lisalupi lisalupi self-assigned this Jan 2, 2025
@lisalupi lisalupi requested a review from matthprost as a code owner January 2, 2025 14:36
Copy link

changeset-bot bot commented Jan 2, 2025

🦋 Changeset detected

Latest commit: 8d2493c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (2205ef6) to head (8d2493c).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4635      +/-   ##
==========================================
+ Coverage   87.43%   87.76%   +0.32%     
==========================================
  Files         335      340       +5     
  Lines       12722    13064     +342     
  Branches     3471     3571     +100     
==========================================
+ Hits        11124    11466     +342     
  Misses       1598     1598              
Files with missing lines Coverage Δ
...rc/components/TimeInputV2/__tests__/helper.test.ts 100.00% <100.00%> (ø)
...rc/components/TimeInputV2/__tests__/index.test.tsx 100.00% <100.00%> (ø)
...ackages/ui/src/components/TimeInputV2/constants.ts 100.00% <100.00%> (ø)
packages/ui/src/components/TimeInputV2/helpers.ts 100.00% <100.00%> (ø)
packages/ui/src/components/TimeInputV2/index.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a40bd38...8d2493c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants