Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture tshark errors and display as warnings #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eprochasson
Copy link

As discussed in issue #64 .

This PR proposes the following:

  • capture the stderr output of tshark and display it as a warning (instead of silently ignoring it)
  • use proper temporary file / directory mechanism for the output of tshark, to avoid collisions.

It has been written with Python 2 and 3 in mind, however I only tested it with Python 3.

I eventually chose not to move the output to logging, as it's a pretty heavy change that will also break compatibility.

Moved fixed tshark dump to securely generated temporary file to avoid collision errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant